Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sre recipes --skip-loadgen flag #852

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

daniel-sanche
Copy link
Member

@daniel-sanche daniel-sanche commented Oct 26, 2021

The Qwiklabs team requested that we add a --skip-loadgen flag to sre recipes, so loadgen tasks can be selectively ignored. They want the option to remove the loadgen cluster to speed up deployment time

This PR adds it as an optional flag, that works with config based recipes. We will add more thourough testing in the next release with #816

#850

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2021
@daniel-sanche daniel-sanche linked an issue Oct 26, 2021 that may be closed by this pull request
@github-actions
Copy link

Open in Cloud Shell
You can also use the Stage Website Action if there were updates to the website.

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

@keenan-devrel keenan-devrel added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 26, 2021
Copy link

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add --skip-loadgenerator flag to sre-recipes
3 participants