New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Redirector (deploy.cloud.run) #16
Comments
That's a great idea, and what I originally had in mind for Google owns Let's start by creating the service that does the redirect, once we have something up, I can take care of the domain. |
SGTM. We can make part of this repo and its build process, and deploy to the same Cloud Run - PROD project. If anyone wants to code up something simple in Go at |
a suggestion was to use |
Can someone sketch out an example for this? I'm having trouble imagining how would this look like. Our current URLs aren't that bad and they're likely to outlive the button (since they're part of Open in Cloud Shell API documented here https://cloud.google.com/shell/docs/open-in-cloud-shell). Unless we do something like Referer check + auto-detect the git repo, I'm not entirely sure if |
I think using a custom domain would:
|
I've confirmed that when a button is clicked from GitHub, it preserves the |
* Add support for Jib Maven builds * Support mvnw wrapper * Add quick check * No *Cmd deref / wrap with detailed error message * Simplify code * Fix error message * James jib maven support (#1) * add shellonly param - fixes #96 (#97) * add shellonly param - fixes #96 * info on param not documented * document deploy.cloud.run - fixes #16 (#98) * Increase caching and reduce layers in Dockerfile (#90) * Increase caching and reduce layers in Dockerfile * Do not download and copy pack * add GOOGLE_APPLICATION_CREDENTIALS env var (#99) * add GOOGLE_APPLICATION_CREDENTIALS env var * multiline * Redirects for /button.{svg,png} (#102) This will do a 301 redirect to the static asset on GCS. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * add error handling (#82) * add error handling * gofmt * return only when error took place * README: add buildpack example (#106) * README: add buildpack example Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * point to new buildpack-samples repo * add page param - fixes #114 (#115) * do not fail on unknown cli flags (#117) This will print a warning about unrecognized cli flags, but will still continue. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * beta->GA, fix domain cmd (#120) Moving cloudrun cmds to use GA CLI set. Also fixing status. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * remove support for git over ssh - fixes #111 (#121) * Add support for Jib Maven builds * Support mvnw wrapper * Add quick check * No *Cmd deref / wrap with detailed error message * Simplify code * Fix error message * instruction cleanup
I think we should create a service (on Cloud Run) which gives us a short and custom URL we can link to for the button so that we can:
So the button href cloud be just something like:
https://cloud.run/deploy
Maybe @steren can chime in on possibly using the existing
cloud.run
domain.The text was updated successfully, but these errors were encountered: