Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector should error on invalid Auto IAM AuthN invocations #283

Closed
enocom opened this issue Aug 22, 2022 · 0 comments · Fixed by #310
Closed

Connector should error on invalid Auto IAM AuthN invocations #283

enocom opened this issue Aug 22, 2022 · 0 comments · Fixed by #310
Assignees
@enocom
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@enocom
Copy link
Member

enocom commented Aug 22, 2022

If a caller enables Auto IAM AuthN for an engine that does not support it (e.g., SQL Server), it should return an error immediately.
@enocom enocom added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 22, 2022
@enocom enocom mentioned this issue Aug 22, 2022
Closed
This was referenced Sep 14, 2022
Closed
Closed
enocom added a commit that referenced this issue Sep 14, 2022
@enocom
fix: verify engine supports Auto IAM AuthN
97e4b65 
Fixes #283.
@enocom enocom mentioned this issue Sep 14, 2022
Merged
enocom added a commit that referenced this issue Oct 7, 2022
@enocom
fix: throw error when Auto IAM AuthN is unsupported (#310)
652e196 
Fixes #283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: throw error when Auto IAM AuthN is unsupported GoogleCloudPlatform/cloud-sql-go-connector
1 participant
@enocom