fix: throw error when Auto IAM AuthN is unsupported #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
suggested changes
Sep 14, 2022
kurtisvg
changed the title
|
@jackwotherspoon Pointed out that a request to generate an ephemeral cert with an access token will return a 40x response for SQL server. So this check probably needs to move into the refresh logic. |
kurtisvg
suggested changes
Oct 7, 2022
|
I moved the check right next to the metadata call and now we get a good error even if the ephemeral certificate call fails. |
kurtisvg
approved these changes
Oct 7, 2022
kurtisvg
approved these changes
Oct 7, 2022
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283.