chore: make rate clearer.

GoogleCloudPlatform · Jul 19, 2023 · bdcab1d · bdcab1d
1 parent bf8ce8f
commit bdcab1d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/core/src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java b/core/src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java
@@ -358,6 +358,6 @@ CloudSqlInstance getCloudSqlInstance(String instanceName, AuthType authType) {
                 credentialFactory,
                 executor,
                 localKeyPair,
-                RateLimiter.create(2.0 / 60.0))); // 2 refresh attempts per minute
+                RateLimiter.create(1.0 / 30.0))); // 1 refresh attempt every 30 seconds
   }
 }
diff --git a/core/src/test/java/com/google/cloud/sql/core/CloudSqlInstanceTest.java b/core/src/test/java/com/google/cloud/sql/core/CloudSqlInstanceTest.java
@@ -76,7 +76,7 @@ public void testCloudSqlInstanceDataRetrievedSuccessfully() throws Exception {
             stubCredentialFactory,
             executorService,
             keyPairFuture,
-            RateLimiter.create(2.0 / 60.0));
+            RateLimiter.create(1.0 / 30.0));
 
     SslData gotSslData = instance.getSslData();
     assertThat(gotSslData).isSameInstanceAs(instanceDataSupplier.response.getSslData());
@@ -110,7 +110,7 @@ public void testInstanceFailsOnConnectionError() throws Exception {
             stubCredentialFactory,
             executorService,
             keyPairFuture,
-            RateLimiter.create(2.0 / 60.0));
+            RateLimiter.create(1.0 / 30.0));
 
     RuntimeException ex = Assert.assertThrows(RuntimeException.class, instance::getSslData);
     assertThat(ex).hasMessageThat().contains("always fails");
@@ -138,7 +138,7 @@ public void testCloudSqlInstanceForcesRefresh() throws Exception {
             stubCredentialFactory,
             executorService,
             keyPairFuture,
-            RateLimiter.create(2.0 / 60.0));
+            RateLimiter.create(1.0 / 30.0));
 
     SslData gotSslData = instance.getSslData();
     assertThat(gotSslData).isSameInstanceAs(sslData);
@@ -178,7 +178,7 @@ public void testGetPreferredIpTypes() throws Exception {
             stubCredentialFactory,
             executorService,
             keyPairFuture,
-            RateLimiter.create(2.0 / 60.0));
+            RateLimiter.create(1.0 / 30.0));
 
     assertThat(instance.getPreferredIp(Arrays.asList("PUBLIC", "PRIVATE"))).isEqualTo("10.1.2.3");
     assertThat(instance.getPreferredIp(Arrays.asList("PUBLIC"))).isEqualTo("10.1.2.3");
@@ -215,7 +215,7 @@ public void testGetPreferredIpTypesThrowsException() throws Exception {
             stubCredentialFactory,
             executorService,
             keyPairFuture,
-            RateLimiter.create(2.0 / 60.0));
+            RateLimiter.create(1.0 / 30.0));
     Assert.assertThrows(
         IllegalArgumentException.class, () -> instance.getPreferredIp(Arrays.asList("PRIVATE")));
   }