New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring Admin API URL #1587

Closed

enocom opened this issue Oct 5, 2023 · 0 comments · Fixed by #1617

Assignees

Labels

priority: p0 type: feature request

Member

enocom commented Oct 5, 2023 •

edited by hessjcg

Loading

Currently we have a private property that supports configuring the SQL Admin API URL. We should add this property to the supported properties in the connection string.

Add two new connection properties: "cloudSqlAdminRootUrl" and "cloudSqlAdminServicePath". These names use the common prefix "cloudSql" and also match the SQLAdmin java api naming scheme for "rootUrl" and "servicePath".

SqlAdminApiFetcher.create() configures the SQLAdmin client library for each connection. Update this method
so that when the admin api and root url are set,

SQLAdmin.Builder adminApiBuilder; // ...
adminApiBuilder.setRootUrl(rootUrl);
adminApiBuilder.setServicePath(servicePath);

Related to #1575.

The text was updated successfully, but these errors were encountered:

enocom added priority: p0 type: feature request labels

enocom assigned hessjcg

product-auto-label bot added the api: cloudsql label

enocom mentioned this issue

Documentation for all configuration properties #1575

Closed

github-actions bot removed the api: cloudsql label

product-auto-label bot added the api: cloudsql label

github-actions bot removed the api: cloudsql label

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

69bf17f

hessjcg mentioned this issue

chore: Create a connector configuration value object #1592

Merged

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

dfd2995

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

c8a81f7

product-auto-label bot added the api: cloudsql label

github-actions bot removed the api: cloudsql label

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

3a637bd

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

d159bfc

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

4156e28

product-auto-label bot added the api: cloudsql label

github-actions bot removed the api: cloudsql label

hessjcg assigned ttosta-google and unassigned hessjcg

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

9b05e65

product-auto-label bot added the api: cloudsql label

github-actions bot removed the api: cloudsql label

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

363d5b6

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

d884f6c

product-auto-label bot added the api: cloudsql label

hessjcg added a commit that referenced this issue


          chore: Create a connector configuration value object (#1592)

ba836d6

Create a value object containing connector configuration properties. This is the stable public Java API that 
configures connectors. All connection configuration property names and defaults are constants on the new
ConnectionConfig class. Logic to interpret a connection Properties object has moved into this class from
CoreSocketFactory. This config object is now passed within the CoreConnectorFactory instead of an long 
argument list.

part of #1587
part of #1226

github-actions bot removed the api: cloudsql label

product-auto-label bot added the api: cloudsql label

github-actions bot removed the api: cloudsql label

ttosta-google mentioned this issue

feat: add support for configuring Admin API URL #1617

Merged

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

d013471

fix: code review comments from @enocom and @ttosta-google

feat: Programatic configuration of the connector (without renaming CoreSocketFactory). Fixes #1226

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

c998818

fix: code review comments from @enocom and @ttosta-google

feat: Programatic configuration of the connector (without renaming CoreSocketFactory). Fixes #1226

ttosta-google closed this as completed in #1617

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

18a71d5

fix: code review comments from @enocom and @ttosta-google

feat: Programatic configuration of the connector (without renaming CoreSocketFactory). Fixes #1226

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

8733c52

fix: code review comments from @enocom and @ttosta-google

feat: Programatic configuration of the connector (without renaming CoreSocketFactory). Fixes #1226

hessjcg added a commit that referenced this issue


          chore: Create a connector properties value object. part of #1587 #1226

7c6047f

fix: code review comments from @enocom and @ttosta-google

feat: Programatic configuration of the connector (without renaming CoreSocketFactory). Fixes #1226

ttosta-google mentioned this issue

Add support for configuring AlloyDB Admin service endpoint GoogleCloudPlatform/alloydb-java-connector#248

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment