feat: add support for configuring Admin API URL #1617
Conversation
|
Note: I will update docs/jdbc.md once the PR #1605 is merged. |
| private static final Pattern GENERATE_EPHEMERAL_CERT_PATTERN = | ||
| Pattern.compile( | ||
| ".*/sql/v1beta4/projects/(?<project>.*)/instances/(?<instance>.*):generateEphemeralCert"); | ||
| "(?<baseUrl>.*)sql/v1beta4/projects/(?<project>.*)/instances/(?<instance>.*):generateEphemeralCert"); |
There was a problem hiding this comment.
Nice. This is as good as an integration test, since it actually exercises the http client.
| return adminRootUrl; | ||
| } | ||
|
|
||
| public String getlAdminServicePath() { |
There was a problem hiding this comment.
I think this is a typo. Maybe it should be getAdminServicePath
There was a problem hiding this comment.
Thank you for catching that. Updated.
docs/r2dbc.md
Outdated
| ### Example | ||
|
|
||
| ```java | ||
| ConnectionFactoryOptions options=ConnectionFactoryOptions.builder() |
There was a problem hiding this comment.
More realistic example strings for the docs:
"https://googleapis.example.com/"
"sqladmin/v1/"
Also, we may want to direct people to see the javadoc for setRootUrl and setServicePath: https://cloud.google.com/java/docs/reference/google-api-client/latest/com.google.api.client.googleapis.services.AbstractGoogleClient.Builder#com_google_api_client_googleapis_services_AbstractGoogleClient_Builder_setRootUrl_java_lang_String_
ttosta-google
force-pushed
the
support-set-admin-api-url
branch
from
b57b171
to
33c40a9
Compare
I don't have a preference. I could remove it. @hessjcg what do you think? |
|
For historical reasons we've always used v1beta4, even though there's a v1. This is to ensure v1beta4 continues to work, given the significant customer usage. |
I think we provide |
Fixes #1587