-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update dependency com.google.auth:google-auth-library-oauth2-http to v1.16.0 #1321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-library-oauth2-http to v1.16.0
hessjcg
force-pushed
the
gh-1294-oauth2-version
branch
from
June 14, 2023 17:02
e5dd407
to
0285e3e
Compare
Closing. I will provide a different approach to these changes split into a few PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual update of this dependency. Something changed between versions 1.13.0 and 1.14.0 that broke authentication across all versions for GitHub Action service account impersonation.
I suspect it has something to do with the bugfix where quota project was handeled improperly in 1.13 and fixed in 1.14. We probably need to set GOOGLE_CLOUD_QUOTA_PROJECT to an appropriate value to fix the tests in the github runner.
See googleapis/google-auth-library-java#1082