Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary instance initialization. #146

Merged
merged 1 commit into from Jun 24, 2019
Merged

Remove unnecessary instance initialization. #146

merged 1 commit into from Jun 24, 2019

Conversation

kurtisvg
Copy link
Contributor

Remove unnecessary instance initialization from postgres module.

@kurtisvg kurtisvg requested a review from netdpb June 21, 2019 22:37
Copy link

@netdpb netdpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Did Error-Prone catch this for you?

@kurtisvg
Copy link
Contributor Author

Interesting. Did Error-Prone catch this for you?

Unfortunately not - a user for GCF noticed RSA keys were still being generated for Postgres.

@kurtisvg kurtisvg merged commit 5b6b480 into master Jun 24, 2019
@kurtisvg kurtisvg deleted the pg-static branch June 24, 2019 15:48
@hravnaas
Copy link

Hi, @kurtisvg, any idea when this will be released, so version 1.0.15 I assume?

@kurtisvg
Copy link
Contributor Author

@hravnaas Yes, I'm currently to release around every 2 months, so the next release should be in a couple of weeks (first week of august) .

You should be able to use a snapshot version to deploy if you clone this repo and build with mvn install before deploying:

<dependency>
    <groupId>com.google.cloud.sql</groupId>
    <artifactId>mysql-socket-factory-connector-j-8</artifactId>
    <version>1.0.15-SNAPSHOT</version>
</dependency>

@kurtisvg kurtisvg mentioned this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants