fix: Pause connection requests after certificate expires until refresh completes. #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
fix-refresh-expired-data
branch
from
6af043a
to
901558d
Compare
hessjcg
force-pushed
the
fix-refresh-futures
branch
from
d6ccb7e
to
9968302
Compare
hessjcg
force-pushed
the
fix-refresh-expired-data
branch
from
901558d
to
f885230
Compare
hessjcg
force-pushed
the
fix-refresh-expired-data
branch
from
17d7d36
to
aec18df
Compare
hessjcg
force-pushed
the
fix-refresh-expired-data
branch
from
aec18df
to
d727280
Compare
enocom
reviewed
Oct 13, 2023
There was a problem hiding this comment.
I think this counts as a feature as we're changing how refresh is done.
I know we've talked about it, but can you make a succinct case why we need this change? It feels like an edge case for when we're in a CPU throttled context, which we need to address more directly with #992.
|
Converting to draft until we decide to move forward. |
hessjcg
force-pushed
the
fix-refresh-expired-data
branch
from
8735aea
to
8eba0b2
Compare
hessjcg
force-pushed
the
gh-1226-named-connection-java-api
branch
2 times, most recently
from
60e5344
to
c0a79a2
Compare
hessjcg
force-pushed
the
fix-refresh-expired-data
branch
from
8eba0b2
to
051b407
Compare
hessjcg
force-pushed
the
gh-1226-named-connection-java-api
branch
23 times, most recently
from
d52c0f4
to
9d12ed4
Compare
hessjcg
force-pushed
the
fix-refresh-expired-data
branch
from
051b407
to
a94f358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application attempts to create a database connection, and the certificate or auth token has expired,
pause until the certificate and token are refreshed. If the token is not refreshed before the timeout, throw
an exception because the connection attempt failed.