Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust default timeouts to allow more retries with the Cloud SQL API. #1696

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

hessjcg
Copy link
Collaborator

@hessjcg hessjcg commented Nov 15, 2023

Set the default connect timeout to 45 seconds. This allows the Refresher to retry at least once after
a failed refresh attempt. (Refresher delay between failed attempts is 30 sec.)

Rename and restructure connect timeout variables to make the code easier to understand.

Fixes #1695.

Copy link
Collaborator

@ttosta-google ttosta-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hessjcg hessjcg merged commit a2dc813 into main Nov 15, 2023
16 checks passed
@hessjcg hessjcg deleted the gh-1695-connect-timeout branch November 15, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql.mysql.JdbcMysqlJ8IntegrationTests: pooledConnectionTest failed
2 participants