chore: use t.TempDir to create temporary test directory
#1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `os.MkdirTemp`
needs to be removed manually by calling `os.RemoveAll`. The error
handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
hessjcg
approved these changes
Jun 29, 2023
enocom
approved these changes
Jun 29, 2023
enocom
changed the title
t.TempDir to create temporary test directoryt.TempDir to create temporary test directory
enocom
requested changes
Jun 30, 2023
There was a problem hiding this comment.
All the integration tests for unix sockets are failing because the temp dir is too long.
Looks like t.TempDir always prepends the test name to the directory name which probably makes it infeasible for use here. See https://docs.studygolang.com/src/testing/testing.go?s=31998:32031#L962.
I'm not sure we can accept this, but if you have other ideas I'd be curious to hear them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces
os.MkdirTempwitht.TempDirin tests. We can use thet.TempDirfunction from thetestingpackage to create temporary directory. The directory created byt.TempDiris automatically removed when the test and all its subtests complete.Reference: https://pkg.go.dev/testing#T.TempDir