Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use t.TempDir to create temporary test directory #1856

Closed
wants to merge 2 commits into from
Closed

chore: use t.TempDir to create temporary test directory #1856

wants to merge 2 commits into from

Commits on Jun 29, 2023

  1. test: use t.TempDir to create temporary test directory 

    This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using `os.MkdirTemp`
needs to be removed manually by calling `os.RemoveAll`. The error
handling boilerplate e.g.
	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}
is also tedious, but `t.TempDir` handles this for us nicely.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
    @Juneezee
    Juneezee committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    a0012e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into test/t.TempDir

    @enocom
    enocom committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    381d202 View commit details
    Browse the repository at this point in the history