Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for if google_sudoers file is empty #762

Closed
wants to merge 7 commits into from

Conversation

cjd
Copy link

@cjd cjd commented Apr 29, 2019

Additional test added to existing test for missing file so can handle additional potential failure mode

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #762 into master will decrease coverage by 0.04%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   97.76%   97.72%   -0.05%     
==========================================
  Files          62       62              
  Lines        4527     4532       +5     
  Branches      232      233       +1     
==========================================
+ Hits         4426     4429       +3     
- Misses         86       88       +2     
  Partials       15       15
Impacted Files Coverage Δ
...e/google_compute_engine/accounts/accounts_utils.py 97.95% <60%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ea8cd...11a7bf9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #762 into master will decrease coverage by 0.04%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   97.76%   97.72%   -0.05%     
==========================================
  Files          62       62              
  Lines        4527     4532       +5     
  Branches      232      233       +1     
==========================================
+ Hits         4426     4429       +3     
- Misses         86       88       +2     
  Partials       15       15
Impacted Files Coverage Δ
...e/google_compute_engine/accounts/accounts_utils.py 97.95% <60%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ea8cd...11a7bf9. Read the comment docs.

@hopkiw
Copy link
Contributor

hopkiw commented Jan 29, 2020

this codebase is deprecated, but this behavior is fixed in the new guest agent

@hopkiw hopkiw closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants