Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework conditionals in Set-WindowsUpdateServer #1933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffallen-google
Copy link

The conditional on line 76 appears to be intended to prevent re-execution after reboot which could cause a reboot loop, but this conditional is also preventing 1st time execution because the test path already exists in a clean install from Windows Server 2019 ISO. Because this test path already exists, registry values based on wu_server_url and wu_server_port are not being set and it is not possible to use a custom server for Windows updates.

In this pull request, the logic has been changed to remove the conditional based on test path existence and instead to set registry values if the new values are different than the current registry. Further the reboot is only performed if registry values are changed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeffallen-google
To complete the pull request process, please assign karnvadaliya after the PR has been reviewed.
You can assign the PR to them by writing /assign @karnvadaliya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EricEdens
Copy link
Contributor

/assign @bkatyl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants