Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CreateGlossary.cs #919

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Update CreateGlossary.cs #919

merged 2 commits into from
Dec 12, 2019

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Dec 10, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
munkhuushmgl
munkhuushmgl reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@munkhuushmgl munkhuushmgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this YOUR_GLOSSARY_DISPLAY_NAME?

@munkhuushmgl
Copy link
Contributor

Tests are not passing i think because i was using create glossary in setup and teardown of every test.

@nnegrey
Copy link
Contributor Author

nnegrey commented Dec 10, 2019

It changes the default not the tests. Are you not passing things in for your tests?

@munkhuushmgl
Copy link
Contributor

It changes the default not the tests. Are you not passing things in for your tests?

Oh you are right, I misunderstood

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 11, 2019
@munkhuushmgl munkhuushmgl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2019
@nnegrey nnegrey added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 12, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@nnegrey nnegrey merged commit bf0501a into master Dec 12, 2019
@nnegrey nnegrey deleted the nnegrey-patch-1 branch December 12, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munkhuushmgl munkhuushmgl munkhuushmgl approved these changes

@beccasaurus beccasaurus Awaiting requested review from beccasaurus

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnegrey @munkhuushmgl @googlebot @kokoro-team