Fixes hang on timeout, tweak cron tests #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ginkgo function panic on failure so waitgroup.Done() never happens and the entire test hangs. Instead we should let GinkgoRecover recover the function and then call waitgroup.Done() from the caller that recovered. Now the test should resolve as pass/fail within 30s. Also tweak cronanything to accept subminute schedules and clamp down timings. Running for 100 runs new run stats are: //oracle/controllers/backupschedulecontroller/functest:functest_test PASSED in 28.5s Stats over 100 runs: max = 28.5s, min = 23.1s, avg = 25.3s, dev = 1.0s Change-Id: I7468c99199a4a93a359d2b2f0afa2d8c00eb3ba8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akinfermo, kurt-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
This failure looks due to us using an old kubebuilder tools for our envtest setup (from k8s 1.19, we have updated most everything else to 1.24). This is likely the cause of some other issues as well. I will wrap the update for this into the next batch of fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ginkgo function panic on failure so waitgroup.Done() never happens and
the entire test hangs. Instead we should let GinkgoRecover recover the
function and then call waitgroup.Done() from the caller that recovered.
Now the test should resolve as pass/fail within 30s.
Also tweak cronanything to accept subminute schedules and clamp down
timings. Running for 100 runs new run stats are:
//oracle/controllers/backupschedulecontroller/functest:functest_test
PASSED in 28.5s
Stats over 100 runs: max = 28.5s, min = 23.1s, avg = 25.3s, dev = 1.0s
Change-Id: I7468c99199a4a93a359d2b2f0afa2d8c00eb3ba8