Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes hang on timeout, tweak cron tests #248

Merged
merged 1 commit into from
Sep 6, 2022

Commits on Sep 1, 2022

  1. Fixes hang on timeout, tweak cron tests

    Ginkgo function panic on failure so waitgroup.Done() never happens and
    the entire test hangs. Instead we should let GinkgoRecover recover the
    function and then call waitgroup.Done() from the caller that recovered.
    Now the test should resolve as pass/fail within 30s.
    
    Also tweak cronanything to accept subminute schedules and clamp down
    timings. Running for 100 runs new run stats are:
    //oracle/controllers/backupschedulecontroller/functest:functest_test
    PASSED in 28.5s
      Stats over 100 runs: max = 28.5s, min = 23.1s, avg = 25.3s, dev = 1.0s
    
    Change-Id: I7468c99199a4a93a359d2b2f0afa2d8c00eb3ba8
    Kurt Kartaltepe committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    98870e3 View commit details
    Browse the repository at this point in the history