Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(style-python): add black for python linting #128

Merged
merged 2 commits into from
Jul 30, 2021
Merged

chore(style-python): add black for python linting #128

merged 2 commits into from
Jul 30, 2021

Conversation

grayside
Copy link
Collaborator

@grayside grayside commented Jul 22, 2021 •
edited
Loading

  • Adds style-python action
  • Updates terraform action to use non-machine name, only run on terraform files (.tf)
  • Caution: Inadequate testing, will follow-up as needed. I expect the worst case is this executes no-ops on all PRs.

Fixes #41

@grayside grayside added productivity persona: maintainer [meta] Related to project maintenance. labels Jul 22, 2021
@grayside grayside self-assigned this Jul 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@grayside grayside requested a review from a team July 22, 2021 22:02
@grayside
Copy link
Collaborator Author

Not sure why it's flagging Dina specifically as only Code Owner, guessing the CODEOWNERS file needs fixing.

@grayside grayside added this to the v0.5.0 milestone Jul 22, 2021
engelke
engelke approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grayside grayside merged commit 5bd4fc0 into main Jul 30, 2021
@engelke engelke deleted the style-python branch September 17, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

@ace-n ace-n ace-n approved these changes

@dinagraves dinagraves Awaiting requested review from dinagraves

Assignees

@grayside grayside

Labels
cla: yes This human has signed the Contributor License Agreement. persona: maintainer [meta] Related to project maintenance. productivity
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Add code style support for Python
3 participants
@grayside @engelke @ace-n