Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

feat(delivery): add user-specified project IDs to Terraform cfg #221

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Oct 25, 2021

No description provided.

@ace-n ace-n requested a review from grayside October 25, 2021 22:51
@ace-n ace-n requested a review from a team as a code owner October 25, 2021 22:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2021
@ace-n ace-n added component: delivery Related to automation, testing, deployment of the application. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2021
@ace-n ace-n changed the title feat(delivery): use user-specified project IDs feat(delivery): add user-specified project IDs to Terraform cfg Oct 25, 2021
Copy link
Collaborator

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this change remove the billing account/emblem suffix, and changes to the cloudbuild.yaml to pass in the full project names?

@ace-n
Copy link
Contributor Author

ace-n commented Oct 26, 2021

I was hoping to keep it more tightly scoped than that, but I can go ahead and do those here.

@ace-n
Copy link
Contributor Author

ace-n commented Oct 26, 2021

Note: I have not tested setup.sh end-to-end yet, as I'm not sure it currently works properly even without these changes.

I'm holding off on that testing until I think it will work, to minimize the changes that I have to make to get it working.

@grayside PLMK if that's an issue for you.

@ace-n ace-n requested a review from grayside October 26, 2021 23:53
@grayside
Copy link
Collaborator

How do you know what's missing if you've not tested?

@ace-n
Copy link
Contributor Author

ace-n commented Oct 27, 2021

I was (previously) comparing it against a known-working setup-v2.sh file that does things like automatically creating projects.

I went ahead and tested it though. tf apply succeeds, and I made some changes to get the Cloud Builds working with user-provided project IDs.

(They fail due to a missing service account issue, which may be due to using an old project with an outdated Terraform config. In any case, that's likely a Terraform problem so I don't think it belongs in this PR.)

@ace-n ace-n merged commit b563e61 into main Oct 27, 2021
@ace-n ace-n deleted the tf-sh branch October 27, 2021 17:38
@grayside grayside added this to the v0.6.0 milestone Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement. component: delivery Related to automation, testing, deployment of the application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants