-
Notifications
You must be signed in to change notification settings - Fork 61
feat(delivery): add user-specified project IDs to Terraform cfg #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this change remove the billing account/emblem suffix, and changes to the cloudbuild.yaml to pass in the full project names?
I was hoping to keep it more tightly scoped than that, but I can go ahead and do those here. |
Note: I have not tested I'm holding off on that testing until I think it will work, to minimize the changes that I have to make to get it working. @grayside PLMK if that's an issue for you. |
How do you know what's missing if you've not tested? |
I was (previously) comparing it against a known-working I went ahead and tested it though. (They fail due to a missing service account issue, which may be due to using an old project with an outdated Terraform config. In any case, that's likely a Terraform problem so I don't think it belongs in this PR.) |
No description provided.