This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
fix: percent_complete error in jinja templating #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute 'percent_complete' fix: resolving jinja template error when percent_complete is undefined fix: minor variable tweak refactor: clean up
pattishin
commented
Jan 11, 2022
grayside
approved these changes
Jan 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Clicking on 'view campaign' link on a campaign card causes the app to error out.
Cloud Run log error below:
Items to verify
Steps to test PR through my local project:
If you go this route, let me know so I can add you manually as an
approverin the project. (Required in order to login)I also may need to redeploy.
api: https://api-byccf5bkda-uc.a.run.app
website: https://website-byccf5bkda-uc.a.run.app/
Steps to test PR locally in your personal project: (Cloud Shell)
Copy
client-libs/directory from root intowebsite/directory before building the image / deploying (itsDockerfilerequires the directory)Build image based on
content-api/directory and deploy in container w/ Cloud Run (name:api)Build image based on
website/directory and deploy in container w/ Cloud Run (name:website)From project root, run
. scripts/configure_auth.sh(Requires website container to exist)Verify the above listed checklist items.
Drive of personal scripts used: (poor man's scripting)
https://drive.google.com/drive/folders/1knOSYk4EKQcuke5wvCMVVB-ifJN7JgNO?usp=sharing