Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

refactor: Streamline setup.sh #693

Merged
merged 16 commits into from
Nov 1, 2022
Merged

refactor: Streamline setup.sh #693

merged 16 commits into from
Nov 1, 2022

Conversation

rogerthatdev
Copy link
Contributor

@rogerthatdev rogerthatdev commented Oct 22, 2022

This PR reduces execution time of setup.sh from around 12 minutes to about 4 minutes and adds a clean-up script for destroying and deleting Emblem-deployed Cloud resources.

This PR will:

  • Add --async flag to gcloud builds submit commands in setup.sh
  • Execute build commands for containers sooner in setup.sh
  • Remove the prompt to setup CI/CD from setup.sh
  • Defaults SKIP_AUTH to true in setup.sh
  • Add a cleanup.sh that cleans up resources via terraform destroy and gcloud (except for Firebase seed data, see Add option for deleting seed data to data seeding build job #692).
  • Add check_for_build_then_run function to setup.sh that will wait for build completion before deploying Run service and build log URL if not successful.

@github-actions github-actions bot added the component: delivery Related to automation, testing, deployment of the application. label Oct 22, 2022
@rogerthatdev rogerthatdev marked this pull request as ready for review October 22, 2022 02:01
@rogerthatdev rogerthatdev requested a review from a team as a code owner October 22, 2022 02:01
@rogerthatdev rogerthatdev changed the title Refactor/streamline setup refactor: Streamline setup.sh Oct 22, 2022
cleanup.sh Show resolved Hide resolved
cleanup.sh Outdated Show resolved Hide resolved
setup.sh Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
@rogerthatdev rogerthatdev marked this pull request as draft October 25, 2022 19:55
@rogerthatdev rogerthatdev marked this pull request as ready for review October 26, 2022 15:46
Copy link
Collaborator

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, but overall good. FWIW, I think this script is now carrying a good amount of technical debt and complexity and think we should consider prioritizing changes around keeping it from growing further.

setup.sh Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
setup.sh Show resolved Hide resolved
@rogerthatdev rogerthatdev merged commit 800748c into main Nov 1, 2022
@rogerthatdev rogerthatdev deleted the refactor/streamline-setup branch January 4, 2023 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: delivery Related to automation, testing, deployment of the application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants