This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component: delivery
Related to automation, testing, deployment of the application.
label
Oct 22, 2022
grayside
suggested changes
Oct 24, 2022
grayside
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions, but overall good. FWIW, I think this script is now carrying a good amount of technical debt and complexity and think we should consider prioritizing changes around keeping it from growing further.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces execution time of
setup.sh
from around 12 minutes to about 4 minutes and adds a clean-up script for destroying and deleting Emblem-deployed Cloud resources.This PR will:
--async
flag togcloud builds submit
commands insetup.sh
setup.sh
setup.sh
setup.sh
cleanup.sh
that cleans up resources viaterraform destroy
andgcloud
(except for Firebase seed data, see Add option for deleting seed data to data seeding build job #692).check_for_build_then_run
function tosetup.sh
that will wait for build completion before deploying Run service and build log URL if not successful.