Terraform and setup.sh #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding debug print statement
grayside
added
component: content-api
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
grayside
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
After further discussion, we've decided to proceed with landing this PR so we have something in place, with the intention of significantly overhauling it in coming weeks to cover more of our requirements. In particular, we want to support multi-environment OR single-project deployments.
engelke
added a commit
that referenced
this pull request
Jul 16, 2021
* Api cleanup (#92) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * Unit tests (#94) * Unit tests * Adding directory * Using alpine image and installing pytest * Using slim image instead * Adding descriptive ID's for the steps * productivity(terraform): correct terraform violations via PR suggestions (#98) * productivity(terraform): correct terraform violations via PR suggestions (fixes #50) * Switch to secrets.GITHUB_TOKEN Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> * Update decisions.md (#108) New decision record * Terraform and setup.sh (#93) Initial terraform setup. Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com>
engelke
added a commit
that referenced
this pull request
Jul 16, 2021
* OpenAPI spec and generated Python library * More operations in spec * Api cleanup (#92) (#101) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * OpenAPI complete, not finished * Client library generated * Update branch to match main (#113) * Api cleanup (#92) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * Unit tests (#94) * Unit tests * Adding directory * Using alpine image and installing pytest * Using slim image instead * Adding descriptive ID's for the steps * productivity(terraform): correct terraform violations via PR suggestions (#98) * productivity(terraform): correct terraform violations via PR suggestions (fixes #50) * Switch to secrets.GITHUB_TOKEN Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> * Update decisions.md (#108) New decision record * Terraform and setup.sh (#93) Initial terraform setup. Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com>
|
Initial fix for #78 |
grayside
added a commit
that referenced
this pull request
Jul 22, 2021
* OpenAPI spec and generated Python library * More operations in spec * Api cleanup (#92) (#101) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * OpenAPI complete, not finished * Client library generated * Update branch to match main (#113) * Api cleanup (#92) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * Unit tests (#94) * Unit tests * Adding directory * Using alpine image and installing pytest * Using slim image instead * Adding descriptive ID's for the steps * productivity(terraform): correct terraform violations via PR suggestions (#98) * productivity(terraform): correct terraform violations via PR suggestions (fixes #50) * Switch to secrets.GITHUB_TOKEN Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> * Update decisions.md (#108) New decision record * Terraform and setup.sh (#93) Initial terraform setup. Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outstanding issues / questions:
stageandprodprojects handle their own rollouts. By which I mean, the cloud build triggers that ramped up traffic lived in these projects. Now, I'm thinking it would be a lot easier from a setup perspective to have theopsproject house all the CI/CD triggers. What do you think? Otherwise, the user will have to connect the same repo to 3 projects.setup.sh[Ignore the messy history of git commits. I should have started from a fresh branch.]