Openapi spec and generated library #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review
google-cla
bot
added
the
cla: yes
ace-n
approved these changes
Jul 16, 2021
| print("Exception when calling DefaultApi->approvers_get: %s\n" % e) | ||
|
|
||
| # create an instance of the API class | ||
| api_instance = swagger_client.DefaultApi(swagger_client.ApiClient(configuration)) |
There was a problem hiding this comment.
Can we reuse previous api_instances here?
If not, we should add a comment explaining that.
(Feel free to ignore this comment if you decide - per my comment below - to split this up into multiple code blocks!)
|
Everything in the client-libs directory is currently autogenerated. Looking into ways to override some of it, but we will leave it as is for now. |
* Api cleanup (#92) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * Unit tests (#94) * Unit tests * Adding directory * Using alpine image and installing pytest * Using slim image instead * Adding descriptive ID's for the steps * productivity(terraform): correct terraform violations via PR suggestions (#98) * productivity(terraform): correct terraform violations via PR suggestions (fixes #50) * Switch to secrets.GITHUB_TOKEN Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> * Update decisions.md (#108) New decision record * Terraform and setup.sh (#93) Initial terraform setup. Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com>
This was referenced Jul 20, 2021
Closed
grayside
added a commit
that referenced
this pull request
Jul 22, 2021
* OpenAPI spec and generated Python library * More operations in spec * Api cleanup (#92) (#101) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * OpenAPI complete, not finished * Client library generated * Update branch to match main (#113) * Api cleanup (#92) * Markdown API docs * Refactored all resource methods to one package * Restored accidentally deleted resources/base * Partial separation of db access from methods * DB separated from method handlers * Added first test * More tests * API functionally complete per current spec * Reformatted by black * Delete , Inadvertent rename, later restored * Address PR #92 comments * Used existing helper method more often * Respond to PR review * Unit tests (#94) * Unit tests * Adding directory * Using alpine image and installing pytest * Using slim image instead * Adding descriptive ID's for the steps * productivity(terraform): correct terraform violations via PR suggestions (#98) * productivity(terraform): correct terraform violations via PR suggestions (fixes #50) * Switch to secrets.GITHUB_TOKEN Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> * Update decisions.md (#108) New decision record * Terraform and setup.sh (#93) Initial terraform setup. Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Adam Ross <adamross@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete spec and library created.