b/158262661: Move snake to json segment mapping to per-operation instead of global #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Name mapping Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
nareddyt
changed the title
Signed-off-by: Teju Nareddy <nareddyt@google.com>
qiwzhang
reviewed
Jul 9, 2020
qiwzhang
reviewed
Jul 9, 2020
TAOXUY
reviewed
Jul 10, 2020
TAOXUY
reviewed
Jul 10, 2020
TAOXUY
reviewed
Jul 10, 2020
qiwzhang
reviewed
Jul 10, 2020
qiwzhang
reviewed
Jul 10, 2020
Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
qiwzhang
reviewed
Jul 10, 2020
qiwzhang
reviewed
Jul 10, 2020
qiwzhang
reviewed
Jul 10, 2020
Signed-off-by: Teju Nareddy <nareddyt@google.com>
Signed-off-by: Teju Nareddy <nareddyt@google.com>
nareddyt
commented
Jul 13, 2020
TAOXUY
approved these changes
Jul 14, 2020
qiwzhang
approved these changes
Jul 14, 2020
nareddyt
added a commit
that referenced
this pull request
Jul 14, 2020
…225) - Added a script to sort example JSONs automatically when running `make format` - Redeployed all examples in `cloudesf-testing`. That way, everyone on the team has permissions to deploy and update them. FYI the diff looks big because this sorts the JSONs alphabetically by key. Semantically, they are identical. The only difference is the name of each API. Unblocks #218
nareddyt
changed the title
# Conflicts: # examples/testdata/path_matcher/envoy_config.json # examples/testdata/path_matcher/openapi_swagger.json # examples/testdata/path_matcher/service_config_generated.json
Signed-off-by: Teju Nareddy <nareddyt@google.com>
qiwzhang
approved these changes
Jul 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nareddyt, qiwzhang, TAOXUY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nareddyt This is a breaking change. Please don't forget to change version to v7. |
Yup, I will make a PR changing to v7 as soon as this is submitted. Don't want to update in this PR, diff will be horrible. |
nareddyt
added a commit
to nareddyt/esp-v2
that referenced
this pull request
Jul 14, 2020
Due to breaking API change in GoogleCloudPlatform#218 Signed-off-by: Teju Nareddy <nareddyt@google.com>
nareddyt
added a commit
that referenced
this pull request
Jul 14, 2020
Due to breaking API change in #218 Signed-off-by: Teju Nareddy <nareddyt@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenAPI specs, a path template jsonName may conflict with the jsonName of well known
google.protobuf.*types. To prevent this, define the snake_to_json segment mapping per operation instead of globally in the path matcher filter. Then the validation of name conflicts will only be per-operation, greatly making the validation less strict.Also optimize when this needs to be configured in the path matcher config. We only pass this when we need path parameter extraction under constant address backend routing.
Diff is too large already. I will follow-up with PRs for:
Ref: https://groups.google.com/u/1/g/google-cloud-endpoints/c/hxyuDx1yrvQ
Closes #185
Signed-off-by: Teju Nareddy nareddyt@google.com