Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata and requirements for gem #219

Merged
merged 2 commits into from Apr 3, 2018
Merged

Update metadata and requirements for gem #219

merged 2 commits into from Apr 3, 2018

Conversation

dhrupadb
Copy link
Contributor

@dhrupadb dhrupadb commented Apr 3, 2018

No description provided.

@qingling128
Copy link
Contributor

Looks good. We probably need to change Travis configuration to remove Ruby 2.1 (that should fail) in the file .travis.yml.

qingling128
qingling128 approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

igorpeshansky
igorpeshansky requested changes Apr 3, 2018
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please make the Travis changes in this PR?

@qingling128
Copy link
Contributor

@igorpeshansky The Travis change has been made it seems. Race condition comment or are you referring to some additional changes needed?

igorpeshansky
igorpeshansky approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a race condition, sorry. LGTM :shipit:

@qingling128 qingling128 merged commit 73abae5 into master Apr 3, 2018
@qingling128 qingling128 deleted the dhrupadb-bump-ruby-requirement branch April 3, 2018 15:21
qingling128 pushed a commit that referenced this pull request Apr 3, 2018
@dhrupadb @qingling128
Update metadata and requirements for gem. (#219)
4b2408e
@qingling128
Copy link
Contributor

fluent-plugin-google-cloud-0.6.18.gem is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dhrupadb @qingling128 @igorpeshansky @googlebot