Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update googleauth version #443

Closed

Conversation

max0ne
Copy link

@max0ne max0ne commented Nov 30, 2020

This fixes #442 . This also updates google-api-client to latest version, and Ruby to version 2.4.0, which are required by latest googleauth.

Verified it passes bundle install

@google-cla google-cla bot added the cla: yes label Nov 30, 2020
Signed-off-by: Mingfei Huang <mingfei.huang@getcruise.com>
@stanhu
Copy link
Contributor

stanhu commented Feb 10, 2021

@qingling128 Yes, can we please get these updated? These old dependencies are making it hard to have the gcloud gem also installed.

@qingling128
Copy link
Contributor

Hi, thanks for the contribution. Bumping required_ruby_version can be potentially considered a breaking change. We'd need to evaluate the impact and run end to end testing on our side. Regarding prioritization, what is the impact of this issue so far?

@stanhu
Copy link
Contributor

stanhu commented Feb 10, 2021

@qingling128 The Ruby update is not as big of an issue as the fixed, stale googleauth and google-api-client dependencies. I think these version requirements should be relaxed. This is one of many production issues we've had over the past year with conflicting dependencies with gcloud related gems: https://gitlab.com/gitlab-com/gl-infra/production/-/issues/3566#note_506065845

@stanhu
Copy link
Contributor

stanhu commented Feb 11, 2021

Take this Gemfile:

# cat /etc/td-agent/Gemfile
source 'https://rubygems.org'

gem 'fluent-plugin-google-cloud', '0.9.1'
gem 'google-cloud-pubsub', '2.3.1'

Now see what happens when trying to use it:

root@default-ubuntu-1604:/home/vagrant# /opt/td-agent/bin/fluentd --gemfile=/etc/td-agent/Gemfile --gem-path=/var/lib/td-agent/vendor/bundle
Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break this application for all non-root users on this machine.
Fetching gem metadata from https://rubygems.org/........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "google-protobuf":
  In Gemfile:
    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      google-protobuf (= 3.12.2)

    google-cloud-pubsub (= 2.3.1) was resolved to 2.3.1, which depends on
      google-cloud-pubsub-v1 (~> 0.0) was resolved to 0.3.0, which depends on
        grpc-google-iam-v1 (< 2.0, >= 0.6.10) was resolved to 0.6.11, which depends on
          google-protobuf (~> 3.14)

Bundler could not find compatible versions for gem "googleapis-common-protos":
  In Gemfile:
    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      googleapis-common-protos (= 1.3.9)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      google-cloud-logging (= 1.6.6) was resolved to 1.6.6, which depends on
        google-gax (~> 1.7) was resolved to 1.8.1, which depends on
          googleapis-common-protos (< 2.0, >= 1.3.9)

    google-cloud-pubsub (= 2.3.1) was resolved to 2.3.1, which depends on
      google-cloud-pubsub-v1 (~> 0.0) was resolved to 0.3.0, which depends on
        grpc-google-iam-v1 (< 2.0, >= 0.6.10) was resolved to 0.6.10, which depends on
          googleapis-common-protos (< 2.0, >= 1.3.10)

Bundler could not find compatible versions for gem "googleapis-common-protos-types":
  In Gemfile:
    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      google-cloud-logging (= 1.6.6) was resolved to 1.6.6, which depends on
        googleapis-common-protos-types (>= 1.0.2)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      opencensus-stackdriver (= 0.3.2) was resolved to 0.3.2, which depends on
        google-cloud-monitoring (~> 0.32) was resolved to 0.38.0, which depends on
          googleapis-common-protos-types (< 2.0, >= 1.0.4)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      grpc (= 1.30.2) was resolved to 1.30.2, which depends on
        googleapis-common-protos-types (~> 1.0)

Bundler could not find compatible versions for gem "googleauth":
  In Gemfile:
    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      googleauth (= 0.9.0)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      google-api-client (= 0.30.8) was resolved to 0.30.8, which depends on
        googleauth (< 0.10.0, >= 0.5)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      google-cloud-logging (= 1.6.6) was resolved to 1.6.6, which depends on
        google-gax (~> 1.7) was resolved to 1.8.1, which depends on
          googleauth (~> 0.9)

Bundler could not find compatible versions for gem "grpc":
  In Gemfile:
    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      grpc (= 1.30.2)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      opencensus-stackdriver (= 0.3.2) was resolved to 0.3.2, which depends on
        google-cloud-trace (~> 0.35) was resolved to 0.40.0, which depends on
          google-cloud-trace-v1 (~> 0.0) was resolved to 0.2.0, which depends on
            gapic-common (~> 0.3) was resolved to 0.3.4, which depends on
              grpc (~> 1.25)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      google-cloud-logging (= 1.6.6) was resolved to 1.6.6, which depends on
        google-gax (~> 1.7) was resolved to 1.8.1, which depends on
          grpc (~> 1.24)

    fluent-plugin-google-cloud (= 0.9.1) was resolved to 0.9.1, which depends on
      googleapis-common-protos (= 1.3.9) was resolved to 1.3.9, which depends on
        grpc (~> 1.0)

    google-cloud-pubsub (= 2.3.1) was resolved to 2.3.1, which depends on
      google-cloud-pubsub-v1 (~> 0.0) was resolved to 0.3.0, which depends on
        grpc-google-iam-v1 (< 2.0, >= 0.6.10) was resolved to 0.6.10, which depends on
          grpc (~> 1.27)

@stanhu
Copy link
Contributor

stanhu commented Feb 11, 2021

Submitted #449 to relax the gem dependencies to fix the issue above.

@yangjiel
Copy link

May I ask how this merge request going? I'm currently having faraday conflict with elasticsearch (required faraday > 1.10.0).

@igorpeshansky
Copy link
Member

This was done, in a slightly different manner, via #504.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version conflict with fluent-plugin-elasticsearch
5 participants