-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update googleauth version #443
Update googleauth version #443
Conversation
32d3819
to
4815ce6
Compare
@qingling128 Yes, can we please get these updated? These old dependencies are making it hard to have the |
Hi, thanks for the contribution. Bumping required_ruby_version can be potentially considered a breaking change. We'd need to evaluate the impact and run end to end testing on our side. Regarding prioritization, what is the impact of this issue so far? |
@qingling128 The Ruby update is not as big of an issue as the fixed, stale |
Take this
Now see what happens when trying to use it:
|
Submitted #449 to relax the gem dependencies to fix the issue above. |
May I ask how this merge request going? I'm currently having faraday conflict with elasticsearch (required faraday > 1.10.0). |
This was done, in a slightly different manner, via #504. |
This fixes #442 . This also updates
google-api-client
to latest version, and Ruby to version 2.4.0, which are required by latestgoogleauth
.Verified it passes
bundle install