Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump grpc gem to 1.43.1 #483

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

perek
Copy link
Contributor

@perek perek commented Feb 9, 2022

Due to a bug in grpc gem you cannot compile this plugin after 10.0 on ARM architecture grpc/grpc#23889

We need to bump this dep up to support native arm extensions

Due to a bug in grpc gem you cannot compile this plugin after 10.0 on ARM architecture grpc/grpc#23889

We need to bump this dep up to support native arm extensions
@@ -27,8 +27,8 @@ eos
gem.add_runtime_dependency 'googleauth', '0.9.0'
gem.add_runtime_dependency 'google-api-client', '0.30.8'
gem.add_runtime_dependency 'google-cloud-logging', '1.6.6'
gem.add_runtime_dependency 'google-protobuf', '3.15.8'
gem.add_runtime_dependency 'grpc', '1.31.1'
gem.add_runtime_dependency 'google-protobuf', '3.18.2'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to bump this as well

Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per evaluation in http://b/219963999, these versions look good. LGTM

@qingling128
Copy link
Contributor

qingling128 commented Mar 17, 2022

Looks like this also requires upgrading to >= Ruby 2.5.0. So there are more validations we need to do internally.

@qingling128
Copy link
Contributor

In fact, I just checked the package. We are already using Ruby 2.6.9 there: https://github.com/GoogleCloudPlatform/google-fluentd/blob/250f1343be7c90f35101c4dae708090d257e6ae6/config/software/ruby.rb#L31. So it should be fine to just remove 2.4 from the testing grid.

@qingling128
Copy link
Contributor

@qingling128 qingling128 merged commit 53a9ee6 into GoogleCloudPlatform:master Mar 17, 2022
@qingling128
Copy link
Contributor

@perek - Some updates: We have a custom build of google-fluentd with this new gem version now. However, the new gRPC version breaks support on a version of Amazon AMI we support (based on CentOS 6), so we might not be able to release a formal version before we can claim end of support for that.

Are you interested in trying out a custom build instead?

@perek
Copy link
Contributor Author

perek commented Mar 22, 2022

@qingling128 yes I am lmk how to consume it

@perek
Copy link
Contributor Author

perek commented Mar 22, 2022

i am building fluentd from scratch, so I think just a new release would work for me too so I can swap the ruby gems

@igorpeshansky
Copy link
Member

@qingling128
Copy link
Contributor

@perek - We might not be able to do a release soon due to the breakage of CentOS 6. If you are building from scratch, would a custom gem push work for you? something like 0.12.5.rc.1?

@igorpeshansky
Copy link
Member

I'm going to try to get our Amazon AMI story under control, so we can actually release.

@perek
Copy link
Contributor Author

perek commented Mar 22, 2022

That will work perfect for me @qingling128

@qingling128
Copy link
Contributor

@jefferbrecht
Copy link
Member

FYI, we're seeing about 15-20 MB increased memory usage overall after upgrading:

image

Purportedly there are some memory fixes in 1.45.0, so I will open a PR to upgrade to it. Not sure if it will make a difference here but it would be good to pick it up anyway on its own merits.

jefferbrecht added a commit that referenced this pull request Apr 8, 2022
Looking to see if this might affect the memory issue identified in #483.
jefferbrecht added a commit that referenced this pull request Apr 8, 2022
Looking to see if this might affect the memory issue identified in #483.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants