-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump grpc gem to 1.43.1 #483
Conversation
Due to a bug in grpc gem you cannot compile this plugin after 10.0 on ARM architecture grpc/grpc#23889 We need to bump this dep up to support native arm extensions
@@ -27,8 +27,8 @@ eos | |||
gem.add_runtime_dependency 'googleauth', '0.9.0' | |||
gem.add_runtime_dependency 'google-api-client', '0.30.8' | |||
gem.add_runtime_dependency 'google-cloud-logging', '1.6.6' | |||
gem.add_runtime_dependency 'google-protobuf', '3.15.8' | |||
gem.add_runtime_dependency 'grpc', '1.31.1' | |||
gem.add_runtime_dependency 'google-protobuf', '3.18.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed to bump this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per evaluation in http://b/219963999, these versions look good. LGTM
Looks like this also requires upgrading to >= Ruby |
In fact, I just checked the package. We are already using Ruby |
@perek - Some updates: We have a custom build of Are you interested in trying out a custom build instead? |
@qingling128 yes I am lmk how to consume it |
i am building fluentd from scratch, so I think just a new release would work for me too so I can swap the ruby gems |
@perek - We might not be able to do a release soon due to the breakage of CentOS 6. If you are building from scratch, would a custom gem push work for you? something like |
I'm going to try to get our Amazon AMI story under control, so we can actually release. |
That will work perfect for me @qingling128 |
Looking to see if this might affect the memory issue identified in #483.
Looking to see if this might affect the memory issue identified in #483.
Due to a bug in grpc gem you cannot compile this plugin after 10.0 on ARM architecture grpc/grpc#23889
We need to bump this dep up to support native arm extensions