fix: remove default fallback when target function does not exist (#497)

Functions framework will no longer load a default function named
'function' if one is exported and the configured target can
not be found. This behavior is unexpected and inconsistent with
other function framework implementations.

src/loader.ts

@@ -121,7 +121,7 @@ export async function getUserFunction(
       return registeredFunction;
     }
 
-    let userFunction = functionTarget
+    const userFunction = functionTarget
       .split('.')
       .reduce((code, functionTargetPart) => {
         if (typeof code === 'undefined') {
@@ -131,18 +131,12 @@ export async function getUserFunction(
         }
       }, functionModule);
 
-    // TODO: do we want 'function' fallback?
     if (typeof userFunction === 'undefined') {
-      // eslint-disable-next-line no-prototype-builtins
-      if (functionModule.hasOwnProperty('function')) {
-        userFunction = functionModule['function'];
-      } else {
-        console.error(
-          `Function '${functionTarget}' is not defined in the provided ` +
-            'module.\nDid you specify the correct target function to execute?'
-        );
-        return null;
-      }
+      console.error(
+        `Function '${functionTarget}' is not defined in the provided ` +
+          'module.\nDid you specify the correct target function to execute?'
+      );
+      return null;
     }
 
     if (typeof userFunction !== 'function') {

test/loader.ts

@@ -93,6 +93,20 @@ describe('loading function', () => {
     }
   }
 
+  it('fails to load a function that does not exist', async () => {
+    FunctionRegistry.http('function', () => {
+      return 'PASS';
+    });
+
+    const loadedFunction = await loader.getUserFunction(
+      process.cwd() + '/test/data/with_main',
+      'functionDoesNotExist',
+      'http'
+    );
+
+    assert.strictEqual(loadedFunction, null);
+  });
+
   it('loads a declaratively registered function', async () => {
     FunctionRegistry.http('registeredFunction', () => {
       return 'PASS';