Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clat-percentile accuracy in fio #1503

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix clat-percentile accuracy in fio #1503

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b682575
Fix clat-percentile accuracy in fio
gargnitingoogle Nov 16, 2023
b53fbfc
address comments
gargnitingoogle Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions perfmetrics/scripts/fio/install_fio.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,17 @@ echo "Installing fio ..."
sudo apt-get install -y libaio-dev

# We are building fio from source because of the issue: https://github.com/axboe/fio/issues/1668.
# The sed command below is to address internal bug#309563824.
# As recorded in this bug, fio by-default supports
# clat percentile values to be calculated accurately upto only
# 2^(FIO_IO_U_PLAT_GROUP_NR + 5) ns = 14 ms
gargnitingoogle marked this conversation as resolved.
Show resolved Hide resolved
# (with default value of FIO_IO_U_PLAT_GROUP_NR = 29). This change increases it upto 32, to allow
raj-prince marked this conversation as resolved.
Show resolved Hide resolved
# latencies upto 112 ms to be calculated accurately.
sudo rm -rf "$FIO_SRC_DIR" && \
git clone https://github.com/axboe/fio.git "$FIO_SRC_DIR" && \
cd "$FIO_SRC_DIR" && \
git checkout fio-3.36 && \
sed -i 's/define \+FIO_IO_U_PLAT_GROUP_NR \+\([0-9]\+\)/define FIO_IO_U_PLAT_GROUP_NR 32/g' stat.h && \
./configure && make && sudo make install

# Now, print the installed fio version for verification
Expand Down