Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clat-percentile accuracy in fio #1503

Merged
merged 2 commits into from Nov 21, 2023
Merged

Fix clat-percentile accuracy in fio #1503

merged 2 commits into from Nov 21, 2023

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Nov 16, 2023 •
edited

Description

This fix is to address internal bug#309563824.
As recorded in this bug, fio by default supports
clat percentile values to be calculated accurately upto only 2^(FIO_IO_U_PLAT_GROUP_NR + 5) ns = 14 ms
(with default value of FIO_IO_U_PLAT_GROUP_NR = 29). This change increases it upto 32, to allow latencies upto 112 ms to be calculated accurately.

This is dependent on #1506 . This fix is bsased on the suggestion in axboe/fio#1668 (comment) .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle added the execute-perf-test Execute performance test in PR label Nov 16, 2023
@gargnitingoogle
Copy link
Collaborator Author

For the record, the perf presubmit tests passed with the current commit of this PR: log .

@gargnitingoogle gargnitingoogle removed the execute-perf-test Execute performance test in PR label Nov 16, 2023
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-fio-clat-percentile-limit branch from 747d22e to 0466819 Compare November 16, 2023 09:40
@gargnitingoogle gargnitingoogle added the execute-perf-test Execute performance test in PR label Nov 16, 2023
@gargnitingoogle gargnitingoogle changed the base branch from master to gargnitin/merge-fio-installations November 16, 2023 09:42
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-fio-clat-percentile-limit branch from 0466819 to 705a092 Compare November 16, 2023 09:51
@gargnitingoogle gargnitingoogle mentioned this pull request Nov 16, 2023
Merged
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-fio-clat-percentile-limit branch from 705a092 to cbac061 Compare November 17, 2023 01:17
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-fio-clat-percentile-limit branch 2 times, most recently from 3d79660 to abebb35 Compare November 17, 2023 11:45
@gargnitingoogle gargnitingoogle changed the base branch from gargnitin/merge-fio-installations to read_cache_release November 17, 2023 11:47
@gargnitingoogle gargnitingoogle changed the base branch from read_cache_release to master November 17, 2023 11:47
@gargnitingoogle gargnitingoogle marked this pull request as draft November 19, 2023 15:39
@gargnitingoogle gargnitingoogle marked this pull request as ready for review November 19, 2023 15:39
@gargnitingoogle
Copy link
Collaborator Author

@raj-prince please review.

@gargnitingoogle
Fix clat-percentile accuracy in fio
b682575 
This fix is to address internal bug#309563824.
As recorded in this bug, fio by default supports
clat percentile values to be calculated accurately upto only
2^(FIO_IO_U_PLAT_GROUP_NR + 5) ns = 14 ms
(with default value of FIO_IO_U_PLAT_GROUP_NR = 29). This change increases it upto 32, to allow
latencies upto 112 ms to be calculated accurately.
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-fio-clat-percentile-limit branch from abebb35 to b682575 Compare November 20, 2023 13:53
raj-prince
raj-prince approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please fix before merging.

  1. Linux tests are failing.
  2. We should run the perf-test to make sure, we are not breaking anything.

@gargnitingoogle
Copy link
Collaborator Author

LGTM. Please fix before merging.

  1. Linux tests are failing.
  2. We should run the perf-test to make sure, we are not breaking anything.
  1. linux-tests passed on re-running..
  2. I have put the label from the start, but not sure why the perf presubmit tests are not running. @Tulsishah can you please check this?

I have tested the install_fio.sh script locally, and it worked. I'll wait till perf presubmit is run and passing.

@gargnitingoogle
Copy link
Collaborator Author

LGTM. Please fix before merging.

  1. Linux tests are failing.
  2. We should run the perf-test to make sure, we are not breaking anything.
  1. linux-tests passed on re-running..
  2. I have put the label from the start, but not sure why the perf presubmit tests are not running. @Tulsishah can you please check this?

I have tested the install_fio.sh script locally, and it worked. I'll wait till perf presubmit is run and passing.

The perf presubmit tests passed: log

fetching results..
showing results...
+--------+------------+--------------+------------+--------------+--------------+
| Branch | File Size | Read BW | Write BW | RandRead BW | RandWrite BW |
+--------+------------+--------------+------------+--------------+--------------+
| Master | 0.25MiB | 450.23MiB/s | 1.15MiB/s | 33.1MiB/s | 1.1MiB/s |
| PR | 0.25MiB | 445.85MiB/s | 1.07MiB/s | 32.81MiB/s | 1.17MiB/s |
| | | | | | |
| | | | | | |
| Master | 48.828MiB | 4698.98MiB/s | 70.91MiB/s | 1081.83MiB/s | 74.21MiB/s |
| PR | 48.828MiB | 4525.32MiB/s | 74.45MiB/s | 1094.78MiB/s | 63.9MiB/s |
| | | | | | |
| | | | | | |
| Master | 976.562MiB | 4385.53MiB/s | 26.43MiB/s | 647.72MiB/s | 20.44MiB/s |
| PR | 976.562MiB | 4604.57MiB/s | 25.7MiB/s | 695.23MiB/s | 7.71MiB/s |
| | | | | | |
| | | | | | |
+--------+------------+--------------+------------+--------------+--------------+

@gargnitingoogle gargnitingoogle merged commit 714f4e7 into master Nov 21, 2023
8 checks passed
@gargnitingoogle gargnitingoogle deleted the gargnitin/fix-fio-clat-percentile-limit branch November 21, 2023 04:12
gargnitingoogle added a commit that referenced this pull request Nov 28, 2023
@gargnitingoogle
Fix clat-percentile accuracy in fio (#1503)
68bde30 
* Fix clat-percentile accuracy in fio

This fix is to address internal bug#309563824.
As recorded in this bug, fio by default supports
clat percentile values to be calculated accurately upto only
2^(FIO_IO_U_PLAT_GROUP_NR + 5) ns = 14 ms
(with default value of FIO_IO_U_PLAT_GROUP_NR = 29). This change increases it upto 32, to allow
latencies upto 112 ms to be calculated accurately.

* address comments
gargnitingoogle added a commit that referenced this pull request Nov 29, 2023
@gargnitingoogle
Fix clat-percentile accuracy in fio (#1503)
4c22477 
* Fix clat-percentile accuracy in fio

This fix is to address internal bug#309563824.
As recorded in this bug, fio by default supports
clat percentile values to be calculated accurately upto only
2^(FIO_IO_U_PLAT_GROUP_NR + 5) ns = 14 ms
(with default value of FIO_IO_U_PLAT_GROUP_NR = 29). This change increases it upto 32, to allow
latencies upto 112 ms to be calculated accurately.

* address comments
gargnitingoogle added a commit that referenced this pull request Nov 29, 2023
@gargnitingoogle
Fix clat-percentile accuracy in fio (#1503)
455b753 
* Fix clat-percentile accuracy in fio

This fix is to address internal bug#309563824.
As recorded in this bug, fio by default supports
clat percentile values to be calculated accurately upto only
2^(FIO_IO_U_PLAT_GROUP_NR + 5) ns = 14 ms
(with default value of FIO_IO_U_PLAT_GROUP_NR = 29). This change increases it upto 32, to allow
latencies upto 112 ms to be calculated accurately.

* address comments
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@sethiay sethiay Awaiting requested review from sethiay

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha

Assignees
No one assigned
Labels
execute-perf-test Execute performance test in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gargnitingoogle @raj-prince