Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collate fio installations at one place #1506

Merged
merged 3 commits into from Nov 20, 2023
Merged

Collate fio installations at one place #1506

merged 3 commits into from Nov 20, 2023

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Nov 16, 2023 •
edited

Description

Currently the commands for installing fio
is duplicated at two different places. This change merges them and puts it into a common script at
perfmetrics/scripts/fio/install_fio.sh and invokes it from both the places.

fio version 3.36 has been released, so we could directly installed that from the fio-3.36 package, but we need to build fio from source for the fix in clat latency calculations .

This is precursor to #1503.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle added the execute-perf-test Execute performance test in PR label Nov 16, 2023
@gargnitingoogle gargnitingoogle mentioned this pull request Nov 16, 2023
Merged
@gargnitingoogle
Collate fio installations at one place
c6c3722 
Currently the commands for installing fio
is duplicated at two different places. This change
merges them and puts it into a common script at
perfmetrics/scripts/fio/install_fio.sh and invokes
it from both the places.
@gargnitingoogle
Copy link
Collaborator Author

@raj-prince please review this first and then #1503 .

raj-prince
raj-prince requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments..

@gargnitingoogle
Use fio-3.36 instead of fio-3.35
4896bd4 
As fio-3.35 apparently doesn't support job_start config.
@gargnitingoogle
Copy link
Collaborator Author

the perf presubmit test has passed: log.

showing results...
+--------+------------+--------------+------------+--------------+--------------+
| Branch | File Size | Read BW | Write BW | RandRead BW | RandWrite BW |
+--------+------------+--------------+------------+--------------+--------------+
| Master | 0.25MiB | 493.99MiB/s | 0.94MiB/s | 34.99MiB/s | 1.1MiB/s |
| PR | 0.25MiB | 445.37MiB/s | 1.09MiB/s | 33.46MiB/s | 1.1MiB/s |
| | | | | | |
| | | | | | |
| Master | 48.828MiB | 4732.38MiB/s | 76.5MiB/s | 1111.49MiB/s | 76.63MiB/s |
| PR | 48.828MiB | 4743.12MiB/s | 56.14MiB/s | 1171.55MiB/s | 79.56MiB/s |
| | | | | | |
| | | | | | |
| Master | 976.562MiB | 4661.63MiB/s | 29.03MiB/s | 663.2MiB/s | 25.39MiB/s |
| PR | 976.562MiB | 4556.66MiB/s | 31.49MiB/s | 753.69MiB/s | 25.16MiB/s |
| | | | | | |
| | | | | | |
+--------+------------+--------------+------------+--------------+--------------+

@gargnitingoogle gargnitingoogle removed the execute-perf-test Execute performance test in PR label Nov 19, 2023
@gargnitingoogle
Copy link
Collaborator Author

@raj-prince please review.

@gargnitingoogle gargnitingoogle merged commit 87326ab into master Nov 20, 2023
8 checks passed
@gargnitingoogle gargnitingoogle deleted the gargnitin/merge-fio-installations branch November 20, 2023 13:48
gargnitingoogle added a commit that referenced this pull request Nov 28, 2023
@gargnitingoogle
Collate fio installations at one place (#1506)
df08f7c 
* Collate fio installations at one place

Currently the commands for installing fio
is duplicated at two different places. This change
merges them and puts it into a common script at
perfmetrics/scripts/fio/install_fio.sh and invokes
it from both the places.

* addressed comments

* Use fio-3.36 instead of fio-3.35

As fio-3.35 apparently doesn't support job_start config.
gargnitingoogle added a commit that referenced this pull request Nov 29, 2023
@gargnitingoogle
Collate fio installations at one place (#1506)
7821340 
* Collate fio installations at one place

Currently the commands for installing fio
is duplicated at two different places. This change
merges them and puts it into a common script at
perfmetrics/scripts/fio/install_fio.sh and invokes
it from both the places.

* addressed comments

* Use fio-3.36 instead of fio-3.35

As fio-3.35 apparently doesn't support job_start config.
gargnitingoogle added a commit that referenced this pull request Nov 29, 2023
@gargnitingoogle
Collate fio installations at one place (#1506)
4f350c5 
* Collate fio installations at one place

Currently the commands for installing fio
is duplicated at two different places. This change
merges them and puts it into a common script at
perfmetrics/scripts/fio/install_fio.sh and invokes
it from both the places.

* addressed comments

* Use fio-3.36 instead of fio-3.35

As fio-3.35 apparently doesn't support job_start config.
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@ashmeenkaur ashmeenkaur ashmeenkaur approved these changes

@sethiay sethiay Awaiting requested review from sethiay

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gargnitingoogle @raj-prince @ashmeenkaur