New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing flag name to cache-file-for-range-read in experiment perf tests. #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
January 9, 2024 06:37
sethiay
previously approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document it somewhere that we need to make changes in both master and development branch.
Done |
sethiay
reviewed
Jan 9, 2024
perfmetrics/scripts/continuous_test/gcp_ubuntu/periodic_experiments/README.md
Show resolved
Hide resolved
sethiay
approved these changes
Jan 10, 2024
gargnitingoogle
pushed a commit
that referenced
this pull request
Jan 17, 2024
…sts. (#1598) * changing flag name * adding note * adding note * changing config name * removing dec release configs
Tulsishah
added a commit
that referenced
this pull request
Jan 17, 2024
* Remove branch name env variable in periodic e2e tests (#1595) * remove branch name env variable * adding git checkout commitId * log failed mount message (#1599) * Changing flag name to cache-file-for-range-read in experiment perf tests. (#1598) * changing flag name * adding note * adding note * changing config name * removing dec release configs --------- Co-authored-by: Tulsi Shah <46474643+Tulsishah@users.noreply.github.com> Co-authored-by: Ashmeen Kaur <57195160+ashmeenkaur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The experiment perf tests are failing as it's looking for
download-file-for-random-read
flag.This change is due to this PR-#1571
Link to the issue in case of a bug fix.
NA
Testing details