Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing flag name to cache-file-for-range-read in experiment perf tests. #1598

Merged
merged 5 commits into from Jan 10, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jan 9, 2024

Description

The experiment perf tests are failing as it's looking for download-file-for-random-read flag.
This change is due to this PR-#1571

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tested locally
  2. Unit tests - NA
  3. Integration tests - NA

sethiay
sethiay previously approved these changes Jan 9, 2024
Copy link
Collaborator

@sethiay sethiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document it somewhere that we need to make changes in both master and development branch.

@Tulsishah
Copy link
Collaborator Author

Please document it somewhere that we need to make changes in both master and development branch.

Done

@Tulsishah Tulsishah requested a review from sethiay January 9, 2024 08:40
@Tulsishah Tulsishah requested a review from sethiay January 9, 2024 10:59
@Tulsishah Tulsishah merged commit 7d30fb4 into master Jan 10, 2024
8 checks passed
gargnitingoogle pushed a commit that referenced this pull request Jan 17, 2024
…sts. (#1598)

* changing flag name

* adding note

* adding note

* changing config name

* removing dec release configs
Tulsishah added a commit that referenced this pull request Jan 17, 2024
* Remove branch name env variable in periodic e2e tests (#1595)

* remove branch name env variable

* adding git checkout commitId

* log failed mount message (#1599)

* Changing flag name to cache-file-for-range-read in experiment perf tests. (#1598)

* changing flag name

* adding note

* adding note

* changing config name

* removing dec release configs

---------

Co-authored-by: Tulsi Shah <46474643+Tulsishah@users.noreply.github.com>
Co-authored-by: Ashmeen Kaur <57195160+ashmeenkaur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants