Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing flag name to cache-file-for-range-read in experiment perf tests. #1598

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Changing flag name to cache-file-for-range-read in experiment perf tests. #1598

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2651cd9
changing flag name
Tulsishah Jan 9, 2024
5d13494
adding note
Tulsishah Jan 9, 2024
96bc3d2
adding note
Tulsishah Jan 9, 2024
fd401b7
changing config name
Tulsishah Jan 9, 2024
1cbf508
removing dec release configs
Tulsishah Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion perfmetrics/scripts/continuous_test/gcp_ubuntu/periodic_experiments/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# Experiment Configuration JSON File README

**NOTE**: If you modify a flag name within the development branch, ensure you also
update the corresponding flag name within the [experiments_configuration.json](https://github.com/GoogleCloudPlatform/gcsfuse/blob/master/perfmetrics/scripts/continuous_test/gcp_ubuntu/periodic_experiments/experiments_configuration.json)
file located in the master branch. This synchronization is crucial for running tests correctly.

## This JSON file contains configurations for different experiments.
### Configuration Format:
```
Expand Down Expand Up @@ -46,4 +51,4 @@

## Uniquely Identifying an Experiment
1. A configuration name uniquely defines an experiment and two experiments can't have same configuration name.
2. Once an experiment configuration has been defined, it is important to note that the gcsfuse flags and branch associated with that configuration cannot be edited directly. If there is a need to modify these values, the right approach is to create a new experiment configuration with the desired changes. This ensures the integrity and consistency of the existing configurations.
2. Once an experiment configuration has been defined, it is important to note that the gcsfuse flags and branch associated with that configuration cannot be edited directly. If there is a need to modify these values, the right approach is to create a new experiment configuration with the desired changes. This ensures the integrity and consistency of the existing configurations.
4 changes: 2 additions & 2 deletions ...cs/scripts/continuous_test/gcp_ubuntu/periodic_experiments/experiments_configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"config_file_flags_as_json": {
"file-cache": {
"max-size-in-mb": -1,
"download-file-for-random-read": true
"cache-file-for-range-read": true
}
},
"branch": "read_cache_release",
Expand All @@ -30,7 +30,7 @@
"config_file_flags_as_json": {
"file-cache": {
"max-size-in-mb": -1,
"download-file-for-random-read": false
"cache-file-for-range-read": false
}
},
"branch": "read_cache_release",
Expand Down