Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCE workflow and instructions #54

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Add GCE workflow and instructions #54

merged 3 commits into from
Feb 19, 2020

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Feb 13, 2020

GCE deployment currently focuses only on container-optimized VMs as noted in the instructions.

Copy link
Contributor

@craigdbarber craigdbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for contributing this! A few notes in-line.

Copy link
Contributor Author

@rakyll rakyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

example-workflows/gce/.github/gce.yaml Show resolved Hide resolved
example-workflows/gce/README.md Show resolved Hide resolved
@rakyll
Copy link
Contributor Author

rakyll commented Feb 14, 2020

GitHub ate one of your comments but I also addressed it. There were nested lists in the doc but they were not rendered correctly due to bad formatting.

Copy link
Contributor

@craigdbarber craigdbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@craigdbarber craigdbarber merged commit 9ef0382 into google-github-actions:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants