Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigtable): add retry for writing data test #1630

Merged
merged 6 commits into from
Aug 4, 2020
Merged

fix(bigtable): add retry for writing data test #1630

merged 6 commits into from
Aug 4, 2020

Conversation

billyjacobson
Copy link
Member

@billyjacobson billyjacobson commented Aug 4, 2020 •
edited by tbpg
Loading

Fixes #1609.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2020
tbpg
tbpg requested changes Aug 4, 2020
View reviewed changes
bigtable/writes/writes_test.go Outdated Show resolved Hide resolved
bigtable/writes/writes_test.go Show resolved Hide resolved
billyjacobson and others added 3 commits August 4, 2020 11:24
@billyjacobson @tbpg
Update bigtable/writes/writes_test.go
106f135 
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
@billyjacobson @tbpg
Update bigtable/writes/writes_test.go
d1aa59c 
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
@billyjacobson
Update writes_test.go
da77082
@billyjacobson billyjacobson added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
tbpg
tbpg approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tbpg tbpg changed the title fix(bigtable): Add retry for writing data test fix(bigtable): add retry for writing data test Aug 4, 2020
@tbpg tbpg merged commit b70e68e into master Aug 4, 2020
@tbpg tbpg deleted the bigtable-flakey-tests branch August 4, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigtable/writes: TestWrites failed
3 participants
@billyjacobson @tbpg @kokoro-team