add appengine/bigquery sample #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Copyright 2015 Google Inc. All rights reserved. | ||
| # Use of this source code is governed by the Apache 2.0 | ||
| # license that can be found in the LICENSE file. | ||
| application: gae-bq-sample |
There was a problem hiding this comment.
Is this still required for App Engine? I think you can specify it on the command line.
|
|
||
| // datasets returns a list with the ids of all the Big Query datasets visible | ||
| // with the given context. | ||
| func datasets(c context.Context) ([]string, error) { |
Change-Id: If75ceaea96e3c6d58d1685a64117e4e43294d531
applied @broady's feedback
| } | ||
|
|
||
| // create a new App Engine context from the request. | ||
| c := appengine.NewContext(r) |
There was a problem hiding this comment.
I think we want c -> ctx.
(ctx because we're using the actual context package now.)
Change-Id: If8f8b10f4e0d9aae1e604fb06e3e8ad65802e76a
More feedback
|
merged e317f76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @broady @markmandel