Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bigtable generation #2424

Merged
merged 4 commits into from
Aug 16, 2018
Merged

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Aug 16, 2018

Fixes #2422.

(This allows the code to work with VS15.8)
The snippet has changed as Location is now no longer a required
field in UpdateCluster.
@amanda-tarafa
Copy link
Contributor

The last commit makes the build fail.

@jskeet
Copy link
Collaborator Author

jskeet commented Aug 16, 2018

Urgh - thanks, will look when I can. (Currently drowning in smallish tasks...)

(This "unbreaks" our analyzers.)
@jskeet
Copy link
Collaborator Author

jskeet commented Aug 16, 2018

Looks like updating the SDK version may fix this. Will need to check that doesn't break Kokoro as well though.

Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit 332e1d6 into googleapis:master Aug 16, 2018
@jskeet jskeet deleted the bigtable-generation branch August 16, 2018 20:55
@jskeet
Copy link
Collaborator Author

jskeet commented Aug 16, 2018

(Will fix Kokoro if it breaks :)

@evildour
Copy link
Contributor

Sorry, just saw this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants