Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action Required] Upgrade your App Engine Standard applications to Go 1.11 or 1.12 before October 1, 2019 #29

Open
tamalsaha opened this issue Jun 27, 2019 · 4 comments

Comments

@tamalsaha
Copy link

@tamalsaha tamalsaha commented Jun 27, 2019

Today, I received an email like this.

Action-Required-Upgrade-your-App-Engine-Standard-applications-to-Go-1-11-or-1-12-before-October-1-2019-tamal-appscode-com-AppsCode-Inc-Mail

Does anyone know what things I need to update?

cc: @rakyll

@rakyll

This comment has been minimized.

Copy link
Member

@rakyll rakyll commented Jun 27, 2019

@zombiezen

This comment has been minimized.

Copy link
Contributor

@zombiezen zombiezen commented Jun 27, 2019

Redeploying the app to Go 1.11 should work without change. If you want to use Go 1.12, then you may have to tweak main.go to load your file without giving a command-line argument, but it should still largely work.

@tamalsaha

This comment has been minimized.

Copy link
Author

@tamalsaha tamalsaha commented Jun 27, 2019

@zombiezen , I tried to change the app.yaml to this.

runtime: go111

handlers:
- url: /.*
  script: _go_app

I get this error: File upload done. ERROR: (gcloud.app.deploy) INVALID_ARGUMENT: script field for handler '/.*' must be set to 'auto' for runtime go111.

https://cloud.google.com/appengine/docs/standard/go111/go-differences page seem to recommend some additional changes.

@davidnewhall

This comment has been minimized.

Copy link

@davidnewhall davidnewhall commented Jul 17, 2019

Change script: to auto instead of _go_app and it seems to work fine on go112.

EDIT: The other thing to note is that appengine.go is no longer used and main.go is built under go 1.12 in app engine. It still works fine, but it should use the PORT environment variable instead of hard coding 8080. Example: golift#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.