Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action Required] Upgrade your App Engine Standard applications to Go 1.11 or 1.12 before October 1, 2019 #29

Closed
tamalsaha opened this issue Jun 27, 2019 · 8 comments

Comments

@tamalsaha
Copy link

tamalsaha commented Jun 27, 2019

Today, I received an email like this.

Action-Required-Upgrade-your-App-Engine-Standard-applications-to-Go-1-11-or-1-12-before-October-1-2019-tamal-appscode-com-AppsCode-Inc-Mail

Does anyone know what things I need to update?

cc: @rakyll

@rakyll
Copy link
Contributor

rakyll commented Jun 27, 2019

cc @broady @zombiezen

@zombiezen
Copy link
Contributor

zombiezen commented Jun 27, 2019

Redeploying the app to Go 1.11 should work without change. If you want to use Go 1.12, then you may have to tweak main.go to load your file without giving a command-line argument, but it should still largely work.

@tamalsaha
Copy link
Author

tamalsaha commented Jun 27, 2019

@zombiezen , I tried to change the app.yaml to this.

runtime: go111

handlers:
- url: /.*
  script: _go_app

I get this error: File upload done. ERROR: (gcloud.app.deploy) INVALID_ARGUMENT: script field for handler '/.*' must be set to 'auto' for runtime go111.

https://cloud.google.com/appengine/docs/standard/go111/go-differences page seem to recommend some additional changes.

@davidnewhall
Copy link

davidnewhall commented Jul 17, 2019

Change script: to auto instead of _go_app and it seems to work fine on go112.

EDIT: The other thing to note is that appengine.go is no longer used and main.go is built under go 1.12 in app engine. It still works fine, but it should use the PORT environment variable instead of hard coding 8080. Example: golift#2

philips pushed a commit to etcd-io/govanityurls that referenced this issue Feb 5, 2020
philips pushed a commit to philips/govanityurls that referenced this issue Feb 5, 2020
Make the required changes to use go112 due to the deprecation of Go 1.9.

Migration doc:
- https://cloud.google.com/appengine/docs/standard/go111/go-differences

References:
- GoogleCloudPlatform#29 (comment)
- etcd-io/maintainers#17
@philips
Copy link
Collaborator

philips commented Feb 5, 2020

@davidnewhall I think I addressed all of these in #34

@davidnewhall
Copy link

davidnewhall commented Feb 6, 2020

I don't think this project is getting more updates. You're probably best off forking or picking one of the up to date forks that already exist. I forked and went hard core with the changes. See here https://github.com/golift/turbovanityurls. Good luck! EDIT: I also need to go do some maintenance and updates..

rakyll pushed a commit that referenced this issue Feb 6, 2020
* app.yaml: update to go112

Make the required changes to use go112 due to the deprecation of Go 1.9.

Migration doc:
- https://cloud.google.com/appengine/docs/standard/go111/go-differences

References:
- #29 (comment)
- etcd-io/maintainers#17

* go.mod: initial commit

Migrate this project to use go.mod and update the README.

This is part of the recommended steps to runtime: go111 and beyond.
https://cloud.google.com/appengine/docs/standard/go111/go-differences

* vendor: add dependent packages

Add all dependencies for the project via vendoring for offline builds.

* travis.yml: drop go 1.6 for 1.12

Go 1.6 is too old to have a number of builtin packages for the latest
appengine package. Remove and update to match app engine version: 1.12.

* appengine.go: remove unused file

From the go111 migration doc:
"The appengine build tag is deprecated and will not be used when
building your app for deployment.  Ensure your code still functions
correctly without it being set."

https://cloud.google.com/appengine/docs/standard/go111/go-differences

* main: respect PORT environment variable

The go111 runtime should use the PORT variable to decide the listening
http port.

"PORT The port that receives HTTP requests."
https://cloud.google.com/appengine/docs/standard/go111/runtime
@rakyll
Copy link
Contributor

rakyll commented Feb 6, 2020

Closed via #34.

(Note: I added some more contributors including @philips to the repo.)

@rakyll rakyll closed this as completed Feb 6, 2020
@davidnewhall
Copy link

davidnewhall commented Feb 6, 2020

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants