Update to use app engine runtime go112 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
philips
commented
Feb 5, 2020
philips
commented
- Update app.yaml
- Introduce go.mod
- Vendor deps
Make the required changes to use go112 due to the deprecation of Go 1.9. Migration doc: - https://cloud.google.com/appengine/docs/standard/go111/go-differences References: - GoogleCloudPlatform#29 (comment) - etcd-io/maintainers#17
Migrate this project to use go.mod and update the README. This is part of the recommended steps to runtime: go111 and beyond. https://cloud.google.com/appengine/docs/standard/go111/go-differences
Add all dependencies for the project via vendoring for offline builds.
Closed
Go 1.6 is too old to have a number of builtin packages for the latest appengine package. Remove and update to match app engine version: 1.12.
From the go111 migration doc: "The appengine build tag is deprecated and will not be used when building your app for deployment. Ensure your code still functions correctly without it being set." https://cloud.google.com/appengine/docs/standard/go111/go-differences
The go111 runtime should use the PORT variable to decide the listening http port. "PORT The port that receives HTTP requests." https://cloud.google.com/appengine/docs/standard/go111/runtime
davidnewhall
reviewed
Feb 6, 2020
| @@ -1,5 +1,5 @@ | |||
| sudo: false | |||
| language: go | |||
| go: | |||
| - 1.6 | |||
| - 1.12 | |||
There was a problem hiding this comment.
1.13 might work better with modules.
davidnewhall
reviewed
Feb 6, 2020
| @@ -0,0 +1,3 @@ | |||
| # This source code refers to The Go Authors for copyright purposes. | |||
There was a problem hiding this comment.
You shouldn't need the vendors checked into the repo with a go.mod file.
rakyll
approved these changes
Feb 6, 2020
|
Thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.