Skip to content

Commit

Permalink
Use respectful code (#1190)
Browse files Browse the repository at this point in the history
* Use respectful code

* Address review comments
  • Loading branch information
dilipped committed Jan 22, 2021
1 parent 41ade77 commit 93a38cf
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
12 changes: 6 additions & 6 deletions CHANGES.md
Expand Up @@ -242,7 +242,7 @@ New Features
------------------
- Added HMAC key management for service accounts. This includes a new "hmac"
command to create/get/list/update/delete HMAC keys on service accounts.
Currently, your project must be whitelisted for use with this new HMAC
Currently, your project must be added to the allowlist for use with this new HMAC
functionality. This restriction will be lifted in the near future.

Bug Fixes
Expand Down Expand Up @@ -330,8 +330,8 @@ New features
- Added Bucket Policy Only support to gsutil. This includes a new
"bucketpolicyonly" command to get/set BPO on existing buckets, as well adding
the ability to set BPO at bucket creation time with "mb -b". Currently, your
project must be whitelisted for use with the new BPO functionality. This
restriction will be lifted in the near future.
project must be added to the allowlist for use with the new BPO functionality.
This restriction will be lifted in the near future.

Bug Fixes
------------------
Expand Down Expand Up @@ -373,8 +373,8 @@ Release 4.34 (release date: 2018-09-11)
=======================================
New features
------------------
- Added bucket lock support to gsutil. Currently, your project must be
whitelisted for use with the new bucket lock functionality. This restriction
- Added bucket lock support to gsutil. Currently, your project must be added to
the allowlist for use with the new bucket lock functionality. This restriction
will be lifted in the near future.

Bug Fixes
Expand Down Expand Up @@ -715,7 +715,7 @@ New Features
configuration file.
- Added the iam commmand, which can be used to set IAM policies on
Google Cloud Storage buckets and objects. This feature is currently in
alpha and requires a whitelist application to use it - see
alpha and requires a safelist application to use it - see
"gsutil help iam" for details.
- The hash command now supports retrieving hashes for cloud objects.

Expand Down
4 changes: 2 additions & 2 deletions gslib/tests/testcase/integration_testcase.py
Expand Up @@ -335,8 +335,8 @@ def ClearPOSIXMetadata(self, obj):

def _ServiceAccountCredentialsPresent(self):
# TODO: Currently, service accounts cannot be project owners (unless
# they are grandfathered). Unfortunately, setting a canned ACL other
# than project-private, the ACL that buckets get by default, removes
# they are exempted for legacy reasons). Unfortunately, setting a canned ACL
# other than project-private, the ACL that buckets get by default, removes
# project-editors access from the bucket ACL. So any canned ACL that would
# actually represent a change the bucket would also orphan the service
# account's access to the bucket. If service accounts can be owners
Expand Down
6 changes: 3 additions & 3 deletions test/.pylintrc_limited
Expand Up @@ -10,7 +10,7 @@
# Profiled execution.
profile=no

# Add <file or directory> to the black list. It should be a base name, not a
# Add <file or directory> to the deny list. It should be a base name, not a
# path. You may set this option multiple times.
# NOTE: To ignore specific directories, use the helper script to run pylint.
# It uses the `find` command's `-prune` action, and it's much easier to
Expand Down Expand Up @@ -41,7 +41,7 @@ load-plugins=
##################################
# TODO: Come back to this approach. We should probably enable error messages
# one at a time, determining which ones are feasible to enable, and
# eventually switch to a blacklist strategy, running all of them except
# eventually switch to a denylist strategy, running all of them except
# the ones we've determined aren't helpful.
# disable=bad-option-value,
# fixme,
Expand All @@ -50,7 +50,7 @@ load-plugins=
# locally-disabled
#
##################################
# Whitelist strategy:
# Allowlist strategy:
disable=all
enable=abstract-class-instantiated,
anomalous-backslash-in-string,
Expand Down

0 comments on commit 93a38cf

Please sign in to comment.