Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add mock for AlloyDB User #1845

Draft
wants to merge 145 commits into
base: master
Choose a base branch
from

Conversation

anhdle-sso
Copy link
Collaborator

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anhdle-sso. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anhdle-sso and others added 27 commits May 20, 2024 22:22
* docs: add feature docs

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

* docs: also link from release notes

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

* Apply suggestions from code review

---------

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
The older version has a CVE (though it does not appear to be reachable)
Wiring up support for our direct controllers here.
A step in running samples more like fixtures.
This was auto-generated using the dev-to-proto tool, and then a few
fixes were made manually:

* Commented out some fields that we aren't supporting yet (with NOTYET)
* Changed some `*Duration` to `*string`
* Fixed up the definition of `Empty`
* Added `+required` annotations
* Fixed up the Spec and Status
* Added some registration boilerplate

Also, I switched to the latest controller-gen in
dev/tasks/generate-crds, so that we can use the `+required` annotation
(and to pick up the omitempty fix)
We now need to support int32
Some APIs may include objects in maps, we want to output those objects
also.
A first-pass at a tool to generate types & map functions.
It's not perfect (v3 vs v1 is tricky), but it's much closer.
acpana and others added 30 commits June 6, 2024 20:06
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
* chore: clean apis/config dir for now

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

* chore: autogen deepcopies

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

* Revert "chore: autogen deepcopies"

This reverts commit ecd7e8c.

---------

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
- Move applier into pkg/applier, simplify parameters
- Split Evaluate and Apply
  - old: expanders [evaluate + apply]
  - new: expanders [evaluate] , expanders [apply]
- Composition API changes
  - Add .status.stages capturing individual stage validation failures
  - Add .generation (to be implemented)
- Jinja2 expander changes
  - unit-tests for Validate() method
  - Implement Validate() method that parser script to capture syntax errors
  - Add python script that calls jinjs2 parser
  - Update dockerfile
- Composition controller changes
  - As part of reconcile, validate all expanders and record failures in
    status
- Tests
  - Add TestSimpleCompositionJinjaValidationFailure that tests the jinja
    syntax failure checks
The test.cnrm.cloud.google.com/reconcile-cookie annotation can be
changed without affecting the "true" desired state, but we special
case the annotation in our filtering, so that it still triggers the
reconciler.

Co-authored-by: alex <8968914+acpana@users.noreply.github.com>
Extract the KCC version into its own file.
Make it available for embed to pull it in.
Make sure that its available in the docker file.
Generated from the proto by dev/tools/proto-to-mapper and then lightly
edited / moved around.
We aim to construct a readable version of the GRPC requests.
This uses our new GRPC collection infrastructure.
This should allow matching of more complex paths (as found in servicenetworking)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet