Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove crds staging dir #1880

Merged
merged 3 commits into from
Jun 4, 2024
Merged

chore: remove crds staging dir #1880

merged 3 commits into from
Jun 4, 2024

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented May 22, 2024

This may have happened as a result of a bad merge. Clean up and run make manifests.

@acpana acpana marked this pull request as ready for review May 23, 2024 00:21
@acpana acpana changed the title chore: run make manifests chore: remove crds staging dir May 23, 2024
@gemmahou
Copy link
Collaborator

gemmahou commented May 23, 2024 •
edited
Loading

Looks good to me, could you also run make ready-pr or make manifests to regenerate the deepcopy file?

Seems like our presubmit/validation didn't catch the manifest diff. Without regenerate it in this PR, it still passed.

@justinsb
Copy link
Collaborator

LGTM on deleting the config directory

I'm not sure I understand what's going on with deepcopy

@acpana
chore: clean apis/config dir for now
1f5ba4b 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana
chore: autogen deepcopies
ecd7e8c 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@gemmahou gemmahou mentioned this pull request May 28, 2024
Merged
2 tasks
@gemmahou
Copy link
Collaborator

Can we rebase this master, re-run make manifests locally(that will re-generate the zz_generated_deepcopy, the two zz_generated_deepcopy diff files will be removed from this PR), and get the presubmit passed.

@gemmahou
Copy link
Collaborator

gemmahou commented Jun 4, 2024

/lgtm
/approve

Thanks!! 💯

@google-oss-prow google-oss-prow bot added the lgtm label Jun 4, 2024
@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gemmahou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fcaf15e into master Jun 4, 2024
14 checks passed
@acpana acpana deleted the acpana/manifests branch June 5, 2024 07:25
anhdle-sso pushed a commit to anhdle-sso/k8s-config-connector that referenced this pull request Jun 6, 2024
@acpana @anhdle-sso
chore: remove crds staging dir (GoogleCloudPlatform#1880)
dda9567 
* chore: clean apis/config dir for now

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

* chore: autogen deepcopies

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

* Revert "chore: autogen deepcopies"

This reverts commit ecd7e8c.

---------

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@yuwenma yuwenma added this to the 1.119 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gemmahou gemmahou

Labels
approved lgtm tide/merge-method-squash
Projects
None yet
Milestone
1.119
Development

Successfully merging this pull request may close these issues.
4 participants
@acpana @gemmahou @justinsb @yuwenma