chore: Refactor registry to be more reusable #1955
Conversation
justinsb
force-pushed
the
refactor_registry
branch
8 times, most recently
from
cbbf85b
to
949c622
Compare
There was a problem hiding this comment.
It's weird that this file shows up here. (Since it looks good, no need to clean it up)
There was a problem hiding this comment.
I'll rebase once we merge #1956 so this goes away
| return registration.model, nil | ||
| } | ||
|
|
||
| func PreferredGVK(gk schema.GroupKind) (schema.GroupVersionKind, bool) { |
|
|
||
| // SupportsIAM returns true if this resource supports IAM (not all GCP resources do). | ||
| // An error will be returned if IsDirect(groupKind) is not true. | ||
| func SupportsIAM(groupKind schema.GroupKind) (bool, error) { |
There was a problem hiding this comment.
I don't see where the registry.SupportsIAM is called. Mind giving me some pointers?
There was a problem hiding this comment.
In pkg/cli/cmd/bulkexport/singleresourceiamclient/singleresourceiamclient.go Generally this refactor is working towards #1877
|
/lgtm /hold one question, otherwise LGTM! And thank you for the change! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
refactor_registry
branch
from
949c622
to
5fb1f8a
Compare
justinsb
force-pushed
the
refactor_registry
branch
from
5fb1f8a
to
b715194
Compare
|
/hold cancel |
We need to move things around to avoid import cycles as we add IAM support.
justinsb
force-pushed
the
refactor_registry
branch
from
b715194
to
37ab45c
Compare
|
/lgtm |
google-oss-prow
bot
merged commit 00c444b
into
GoogleCloudPlatform:master
We need to move things around to avoid import cycles as we add IAM
support.