-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting IAM on PrivateCACAPool #1877
Support setting IAM on PrivateCACAPool #1877
Conversation
0de3255
to
4ce16ba
Compare
3e4e677
to
0f9e425
Compare
0f9e425
to
728dae6
Compare
3937f94
to
bf626e4
Compare
70d852c
to
6e9ca35
Compare
ed36fe1
to
7f976c1
Compare
This uses our direct actuation framework.
7f976c1
to
257598e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Looks great and thank you updating the controller template! (Sorry for the delayed review, this PR takes especially long time to understand).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ae65499
into
GoogleCloudPlatform:master
We do this in our direct controller, though we only need to implement the (new) IAM-related methods.
These methods are optional (at least for now!)