-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase maxIdleConnection limit when creating etcd client in apiserver. #7353
Conversation
lgtm. |
Will merge on green |
lgtm |
// dial attempts to open a TCP connection to the provided address, explicitly | ||
// enabling keep-alives with a one-second interval. | ||
// | ||
// TODO: This is copy-pasted from etcd.Client.dial(), since that method isn't public. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( Unfortunately, that means it needs to be located in a file in third_party
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where exactly I should move it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a new directory/file in ``third_party/forked//.go` and make it a public function there. Also include the third party LICENSE and any header at the top of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my ignorance here - but what should LICENCE file contain?
Any of files under Godeps/_workspace/src/github.com/coreos/go-etcd/etcd doesn't contain any licence-related header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, don't put the license or the header in. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sillsm to verify that I'm recalling the instructions correctly...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I really wanted to merge this but we should probably keep the lawyercats happy. |
a7ed8f0
to
07400f9
Compare
PTAL |
@lavalamp I hope that the current directory structure is fine - if not please let me know. |
LGTM |
Increase maxIdleConnection limit when creating etcd client in apiserver.
Rather than forking this, it might be easier to reuse our existing TLS transport options:
|
Fix #7160
cc @fgrzadkowski @lavalamp @xiang90