Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling Updates: Add support for --rollback. #7575

Merged
merged 1 commit into from May 6, 2015

Conversation

brendandburns
Copy link
Contributor

@j3ffml j3ffml self-assigned this Apr 30, 2015
@j3ffml
Copy link
Contributor

j3ffml commented Apr 30, 2015

Looks good, though I would prefer --rollback as the flag name. kubectl rolling update --abort doesn't do a good job of conveying "do a rolling update but in reverse". Will see what others think.

@bgrant0607
Copy link
Member

I also am not a fan of abort. I believe @thockin feels similarly.

@bgrant0607
Copy link
Member

Fixes #4140

@bgrant0607
Copy link
Member

Previous discussion:
#6713 (comment)

@brendandburns
Copy link
Contributor Author

I don't super care. If the preference is for --rollback I will switch this PR, and update the docs. Please let me know, I'd like to get this merged.

@bgrant0607
Copy link
Member

I'm fine with either --abort or --rollback, and will accept the consensus. When talking about it, I'm sure I'll continue to say "rollback".

Additionally, FWIW, a reasonably common pattern internally is for teams to leave the old template around until the next rollout, to facilitate easy rollback. I'd like to expose the "preserve" cleanup policy and would like to support rollback/abort in the scenario where the rollout actually completed but the old RC was not deleted. Don't know if that changes your opinion about which is more appropriate or not.

@ironcladlou
Copy link
Contributor

Thinking about this feature in the context of #1743, what effect would this feature have on the proposed monotonic revision number for deployments?

@brendandburns
Copy link
Contributor Author

@ironcladlou I don't think it should have any effect. At the API level, this is actually a roll-forward to the old version.

That said, maybe you actually want the revision number to rewind?

Can we have a vote on --rollback vs. --abort? I'd like to get this PR merged.

@ironcladlou
Copy link
Contributor

Allow me to cast my vote for...

--rollback

@derekwaynecarr
Copy link
Member

--rollback

Sent from my iPhone

On May 1, 2015, at 3:41 PM, Dan Mace notifications@github.com wrote:

Allow me to cast my vote for...

--rollback


Reply to this email directly or view it on GitHub.

@pmorie
Copy link
Member

pmorie commented May 1, 2015

--rollback (fwiw)

@brendandburns
Copy link
Contributor Author

Switched to --rollback by popular opinion. Updated docs to match.

ptal
Thanks!
--brendan

@j3ffml
Copy link
Contributor

j3ffml commented May 2, 2015

lgtm. will merge on green if no objections

@brendandburns brendandburns changed the title Add support for --abort. Rolling Updates: Add support for --rollback. May 2, 2015
@bgrant0607
Copy link
Member

There's no test. Did you at least try this?

The rename cleanup policy is the default. Does that make sense in this case?

@brendandburns
Copy link
Contributor Author

Yes, this has been manually tested. Without a better test framework in place this is tricky to test in an automated way. I could probably get something going in test-cmd.sh if that is required.

Thanks
--brendan

@j3ffml
Copy link
Contributor

j3ffml commented May 6, 2015

lgtm, but you should probably change the commit description

@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 6, 2015
@bgrant0607
Copy link
Member

The commit description does still refer to --abort

@brendandburns
Copy link
Contributor Author

Changed the commit description.

Thanks!
--brendan

bgrant0607 added a commit that referenced this pull request May 6, 2015
Rolling Updates: Add support for --rollback.
@bgrant0607 bgrant0607 merged commit 32b4b1c into kubernetes:master May 6, 2015
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Rolling Updates: Add support for --rollback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully fail a rolling update?
7 participants