Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rolling Updates: Add support for --rollback. #7575
I'm fine with either --abort or --rollback, and will accept the consensus. When talking about it, I'm sure I'll continue to say "rollback".
Additionally, FWIW, a reasonably common pattern internally is for teams to leave the old template around until the next rollout, to facilitate easy rollback. I'd like to expose the "preserve" cleanup policy and would like to support rollback/abort in the scenario where the rollout actually completed but the old RC was not deleted. Don't know if that changes your opinion about which is more appropriate or not.
@ironcladlou I don't think it should have any effect. At the API level, this is actually a roll-forward to the old version.
That said, maybe you actually want the revision number to rewind?
Can we have a vote on --rollback vs. --abort? I'd like to get this PR merged.