-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add containerized option to kubelet binary #7741
Conversation
@@ -213,6 +215,7 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) { | |||
// Flags intended for testing, not recommended used in production environments. | |||
fs.BoolVar(&s.ReallyCrashForTesting, "really-crash-for-testing", s.ReallyCrashForTesting, "If true, when panics occur crash. Intended for testing.") | |||
fs.Float64Var(&s.ChaosChance, "chaos-chance", s.ChaosChance, "If > 0.0, introduce random client errors and latency. Intended for testing. [default=0.0]") | |||
fs.BoolVar(&s.Containerized, "containerized", s.Containerized, "Experimental support for running kubelet in a container. Intended for testing.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add "Default: false"
LGTM |
@vmarmol Fixed |
Thanks @pmorie! Will merge on green. |
@vmarmol tomorrow I'll do PRs for the image and local-up-cluster accommodation for this use-case |
Add containerized option to kubelet binary
Awesome! Merged :) |
This PR broke the non-linux builds:
|
Dang
|
My bad! I will fix
|
No worries, should have caught it in review. Also, we're not running build cross in CI? Let me look into fixing that. |
@vmarmol PTAL