-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update_encoder to target proxy compute resources #10261
Add update_encoder to target proxy compute resources #10261
Conversation
616e5ea
to
f47ad86
Compare
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
a45e519
to
0102f2d
Compare
Tests analyticsTotal tests: Click here to see the affected service packages
|
@BBBmau Gentle reminder |
/gcbrun |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeDisk_encryptionKMS|TestAccComputeDisk_pdHyperDiskEnableConfidentialCompute|TestAccComputeImage_imageEncryptionKey|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeInstance_confidentialHyperDiskBootDisk|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey |
|
0102f2d
to
eb10c78
Compare
@BBBmau |
Tests analyticsTotal tests: Click here to see the affected service packages
|
@BBBmau Gentle reminder |
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
…form#10261) Co-authored-by: Hamza Hassan <hamzahassan@google.com>
Add update_encoder to
ComputeTargetHttpsProxy
andComputeRegionTargetHttpsProxy
resources.In case a customer changes the field certificate_manager_certificate, the encoder logic does not get applied. I fixed this by using
update_encoder
which is the same as the encoder.The reason that encoder is not applied during the update might relate to the fact that those resources are immutable, though there is a field-specific-update that overrides this (see the YAQ question below)
Fixes: hashicorp/terraform-provider-google/issues/17641
yaqs/2098594962982567936
b/329516022
Release Note Template for Downstream PRs (will be copied)