Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update_encoder to target proxy compute resources #10261

Conversation

Hamzawy63
Copy link
Contributor

@Hamzawy63 Hamzawy63 commented Mar 22, 2024

Add update_encoder to ComputeTargetHttpsProxy and ComputeRegionTargetHttpsProxy resources.

In case a customer changes the field certificate_manager_certificate, the encoder logic does not get applied. I fixed this by using update_encoder which is the same as the encoder.

The reason that encoder is not applied during the update might relate to the fact that those resources are immutable, though there is a field-specific-update that overrides this (see the YAQ question below)

Fixes: hashicorp/terraform-provider-google/issues/17641

yaqs/2098594962982567936
b/329516022

Release Note Template for Downstream PRs (will be copied)

compute: Added explicit update_encoder to `ComputeTargetHttpsProxy` and `ComputeRegionTargetHttpsProxy` resources.

@Hamzawy63 Hamzawy63 force-pushed the compute-traget-fix-encoder-does-not-work-during-updates branch from 616e5ea to f47ad86 Compare March 22, 2024 16:52
@Hamzawy63 Hamzawy63 marked this pull request as ready for review March 22, 2024 17:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau March 22, 2024 17:16
@Hamzawy63 Hamzawy63 force-pushed the compute-traget-fix-encoder-does-not-work-during-updates branch from a45e519 to 0102f2d Compare March 22, 2024 20:41
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 61 insertions(+))
google-beta provider: Diff ( 2 files changed, 61 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 891
Passed tests: 819
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@Hamzawy63
Copy link
Contributor Author

@BBBmau Gentle reminder

@BBBmau
Copy link
Collaborator

BBBmau commented Mar 26, 2024

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Mar 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 61 insertions(+))
google-beta provider: Diff ( 2 files changed, 61 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 891
Passed tests: 809
Skipped tests: 72
Affected tests: 10

Click here to see the affected service packages
  • compute

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeDisk_encryptionKMS|TestAccComputeDisk_pdHyperDiskEnableConfidentialCompute|TestAccComputeImage_imageEncryptionKey|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeInstance_confidentialHyperDiskBootDisk|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_encryptionKMS[Error message] [Debug log]
TestAccComputeDisk_pdHyperDiskEnableConfidentialCompute[Error message] [Debug log]
TestAccComputeImage_imageEncryptionKey[Error message] [Debug log]
TestAccComputeInstanceTemplate_EncryptKMS[Error message] [Debug log]
TestAccComputeInstanceTemplate_sourceImageEncryptionKey[Error message] [Debug log]
TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey[Error message] [Debug log]
TestAccComputeInstance_confidentialHyperDiskBootDisk[Error message] [Debug log]
TestAccComputeInstance_kmsDiskEncryption[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@Hamzawy63 Hamzawy63 force-pushed the compute-traget-fix-encoder-does-not-work-during-updates branch from 0102f2d to eb10c78 Compare March 27, 2024 11:47
@Hamzawy63
Copy link
Contributor Author

Hamzawy63 commented Mar 27, 2024

@BBBmau
I don't think that those failing tests are relevant to my change. Anyways, I rebased my branch on the latest version of origin/main (In case that was the reason)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 61 insertions(+))
google-beta provider: Diff ( 2 files changed, 61 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 891
Passed tests: 819
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@Hamzawy63
Copy link
Contributor Author

@BBBmau Gentle reminder

@BBBmau BBBmau merged commit 6512a3d into GoogleCloudPlatform:main Mar 30, 2024
12 of 13 checks passed
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants